chore(nix): add basedpyright to development shell #61
Conversation
Added basedpyright as a build input to the Nix devShell to provide IDE support for Python type checking. This tool complements the existing mypy hooks and improves developer experience with real-time type feedback in editors.
There was a problem hiding this comment.
Pull request overview
This PR adds basedpyright (a Python type checker and language server) to the Nix development shell to provide real-time type checking feedback in IDEs. This complements the existing mypy configuration which runs as a pre-commit hook.
Key Changes:
- Added basedpyright package to the devShell buildInputs in flake.nix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| nixfmt-rfc-style | ||
| typos | ||
| typos-lsp | ||
| basedpyright |
There was a problem hiding this comment.
Adding basedpyright to the development shell without corresponding configuration may lead to inconsistent type checking behavior. The project already has comprehensive mypy configuration in pyproject.toml (lines 99-125) but lacks any basedpyright configuration. Consider adding a [tool.basedpyright] section to pyproject.toml or a pyrightconfig.json file to ensure basedpyright uses settings consistent with your existing mypy configuration (such as Python version 3.10, strict type checking settings, and module ignore patterns for bm25s, langgraph, and mcp).
| basedpyright |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
add basedpyright for lsp
Summary by cubic
Adds basedpyright to the Nix devShell for Python type checking in IDEs. Complements existing mypy hooks with fast, real-time feedback.
Written for commit c24874e. Summary will update automatically on new commits.