Skip to content

chore(nix): add basedpyright to development shell #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 1 commit into from
Dec 19, 2025
Merged

chore(nix): add basedpyright to development shell #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
nixfmt-rfc-style
typos
typos-lsp
basedpyright
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding basedpyright to the development shell without corresponding configuration may lead to inconsistent type checking behavior. The project already has comprehensive mypy configuration in pyproject.toml (lines 99-125) but lacks any basedpyright configuration. Consider adding a [tool.basedpyright] section to pyproject.toml or a pyrightconfig.json file to ensure basedpyright uses settings consistent with your existing mypy configuration (such as Python version 3.10, strict type checking settings, and module ignore patterns for bm25s, langgraph, and mcp).

Suggested change
basedpyright

Copilot uses AI. Check for mistakes.
];

shellHook = ''
Expand Down