-
Notifications
You must be signed in to change notification settings - Fork 171
Add GitHub Actions workflow for NuGet packaging #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary - All Code Coverage (ubuntu-latest)
|
.github/workflows/package.yml
Outdated
| name: unsigned-packages | ||
| path: ${{ github.workspace }}/packages/**/*.nupkg | ||
|
|
||
| retention-days: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why reduce the default retention of 90 days to only 7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a bit excessive to have an artifact for unsigned packages, an artifact for signed packages, AND packages uploaded to the DevOps feed... I originally had the retention here set at 1 day since this artifact is only intended for staging the packages between jobs. I'm not sure how much it ultimately matters, but my thought was to set this for a short retention to underscore the nature of this being very temporary storage
f ff try fix skip login retry more try shell re-enter secrets change description trim whitespace try alt add shorter workflow x move up fix add checkout alt login z restore fix change
- add tag push trigger - use separate jobs for signed vs unsigned deploy to dev feed
|
|
Superseded by #1546. |



Description
{A detailed description}
Fixes #{bug number}
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.