-
Notifications
You must be signed in to change notification settings - Fork 171
Add GitHub Actions workflow for NuGet packaging (consolidated) #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3da4a2a to
f70ac34
Compare
Summary - All Code Coverage (ubuntu-latest)
|
44771fc to
c516ed1
Compare
09fcd58 to
9098bc8
Compare
9098bc8 to
6ba6fc7
Compare
6ba6fc7 to
0d1511f
Compare
8a81785 to
e95b020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces Nerdbank.GitVersioning (NBGV) with simpler custom versioning logic and migrates from Azure DevOps to GitHub Actions for NuGet packaging, signing, and deployment.
- Removes NBGV dependencies and configuration files, implementing custom version calculation in GitHub Actions
- Introduces a comprehensive GitHub Actions workflow for building, signing, and deploying packages to both development feeds and nuget.org
- Updates CI/CD workflows to remove NBGV-related steps and build server detection logic
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| versions.props | Removes NerdbankGitVersioning package reference |
| version.json | Deletes NBGV configuration file |
| shared.props | Removes NBGV package reference from all projects |
| shared-package.props | Adds manual version properties and updates CI detection |
| build/package.yml | Deletes Azure DevOps packaging pipeline |
| .github/workflows/package.yml | Implements comprehensive GitHub Actions packaging workflow |
| .github/workflows/*.yml | Removes NBGV-related steps from CI workflows |
| src/Steeltoe.All.sln | Updates solution file references and removes build folder |
c32b9c8 to
483e4a5
Compare
d4435be to
1f41e34
Compare
|
TimHess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!



Description
Replaces NBGV with simpler logic to determine the Steeltoe package version.
Replaces Azure DevOps packaging, signing and uploading with a GitHub Actions workflow.
This PR consolidates the changes from #1538 and #1544.
Fixes #1543. Fixes #1512.
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.