Skip to content

Conversation

@bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Jul 16, 2025

Description

Replaces NBGV with simpler logic to determine the Steeltoe package version.
Replaces Azure DevOps packaging, signing and uploading with a GitHub Actions workflow.

This PR consolidates the changes from #1538 and #1544.

Fixes #1543. Fixes #1512.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware force-pushed the gha-package-consolidated branch 2 times, most recently from 3da4a2a to f70ac34 Compare July 16, 2025 12:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 85.6% 79.8%
Steeltoe.Common.Certificates 96.2% 85.2%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 41.6%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 97.8% 92.6%
Steeltoe.Configuration.CloudFoundry 99.1% 91.6%
Steeltoe.Configuration.ConfigServer 97.2% 91.5%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.4% 95.4%
Steeltoe.Connectors 94.8% 90%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 90.4% 100%
Steeltoe.Discovery.Consul 97.7% 94.8%
Steeltoe.Discovery.Eureka 92.5% 85.2%
Steeltoe.Discovery.HttpClients 94% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.5% 89.1%
Steeltoe.Management.Prometheus 95.9% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.3% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware force-pushed the gha-package-consolidated branch 2 times, most recently from 44771fc to c516ed1 Compare July 16, 2025 12:54
@bart-vmware bart-vmware force-pushed the gha-package-consolidated branch from 09fcd58 to 9098bc8 Compare July 16, 2025 13:25
@bart-vmware bart-vmware force-pushed the gha-package-consolidated branch from 9098bc8 to 6ba6fc7 Compare July 16, 2025 13:35
@bart-vmware bart-vmware force-pushed the gha-package-consolidated branch from 6ba6fc7 to 0d1511f Compare July 16, 2025 13:57
@bart-vmware bart-vmware force-pushed the gha-package-consolidated branch from 8a81785 to e95b020 Compare July 16, 2025 14:48
@bart-vmware bart-vmware marked this pull request as ready for review July 16, 2025 14:49
@bart-vmware bart-vmware requested review from TimHess and Copilot July 16, 2025 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces Nerdbank.GitVersioning (NBGV) with simpler custom versioning logic and migrates from Azure DevOps to GitHub Actions for NuGet packaging, signing, and deployment.

  • Removes NBGV dependencies and configuration files, implementing custom version calculation in GitHub Actions
  • Introduces a comprehensive GitHub Actions workflow for building, signing, and deploying packages to both development feeds and nuget.org
  • Updates CI/CD workflows to remove NBGV-related steps and build server detection logic

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
versions.props Removes NerdbankGitVersioning package reference
version.json Deletes NBGV configuration file
shared.props Removes NBGV package reference from all projects
shared-package.props Adds manual version properties and updates CI detection
build/package.yml Deletes Azure DevOps packaging pipeline
.github/workflows/package.yml Implements comprehensive GitHub Actions packaging workflow
.github/workflows/*.yml Removes NBGV-related steps from CI workflows
src/Steeltoe.All.sln Updates solution file references and removes build folder

@bart-vmware bart-vmware force-pushed the gha-package-consolidated branch 2 times, most recently from c32b9c8 to 483e4a5 Compare July 16, 2025 15:15
@sonarqubecloud
Copy link

Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bart-vmware bart-vmware merged commit ff3afbe into main Jul 17, 2025
37 of 40 checks passed
@bart-vmware bart-vmware deleted the gha-package-consolidated branch July 17, 2025 08:57
@bart-vmware bart-vmware added ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/infrastructure labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify package versioning Warning during package signing

3 participants