fix(referencing): accept https $schema for drafts 04/06/07 and add tests #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The draft auto-detection only recognized http:// URLs for draft-04/06/07, rejecting the widely used https:// forms. This caused �Unknown specification� errors for schemas like: - https://json-schema.org/draft-07/schema - https://json-schema.org/draft-06/schema - https://json-schema.org/draft-04/schema This change updates detect() to accept both http and https for all known drafts (including completeness for 2019-09 and 2020-12). Behavioral impact: - CLI and library no longer fail on HTTPS $schema values for draft-04/06/07. Tests: - Add unit cases for HTTPS on drafts 07/06/04 in crates/jsonschema-referencing/src/specification/mod.rs Refs: Stranger6667#802
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
=======================================
Coverage 85.38% 85.39%
=======================================
Files 95 95
Lines 14605 14611 +6
=======================================
+ Hits 12471 12477 +6
Misses 2134 2134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #803 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The draft auto-detection only recognized http:// URLs for draft-04/06/07,
rejecting the widely used https:// forms. This caused <U+0093>Unknown specification<U+0094>
errors for schemas like:
This change updates detect() to accept both http and https for all known
drafts (including completeness for 2019-09 and 2020-12).
Behavioral impact:
Tests:
Refs: #802