Fix config prefix logic for configurable addons #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the config prefix to addons that don't have a `config` object defined in their `manifest.json`, but do have `manifest.behaviorHints.configurable` set to `true`. This is the case for addons with a custom configuration page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the config prefix to addons that don't have a
configobject defined in theirmanifest.json, but do havemanifest.behaviorHints.configurableset totrue. This is the case for addons with a custom configuration page.Not 100% sure if it makes sense to support this in the official SDK. It's something I'm adding to the unofficial community SDK at Stremio-Community/stremio-addon-sdk#27 and figured to create this PR to upstream the changes just in case it's useful.