Skip to content

Fix config prefix logic for configurable addons #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sleeyax wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix config prefix logic for configurable addons #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/getRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@ function getRouter({ manifest , get }) {
res.end(manifestRespBuf)
}

const hasConfigBehaviorHint = (manifest.behaviorHints || {}).configurable
const hasConfig = (manifest.config || []).length

if (hasConfig && !(manifest.behaviorHints || {}).configurable) {
if (hasConfig && !hasConfigBehaviorHint) {
console.warn('manifest.config is set but manifest.behaviorHints.configurable is disabled, the "Configure" button will not show in the Stremio apps')
}

const configPrefix = hasConfig ? '/:config?' : ''
const configPrefix = hasConfig || hasConfigBehaviorHint ? '/:config?' : ''
// having config prifix always set to '/:config?' won't resault in a problem for non configurable addons,
// since now the order is restricted by resources.

Expand Down