Fix #652 - Use internal/user datetime to calculate GMT offset#654
Open
scicali wants to merge 3 commits intoSuiteCRM:hotfixfrom
Open
Fix #652 - Use internal/user datetime to calculate GMT offset#654scicali wants to merge 3 commits intoSuiteCRM:hotfixfrom
scicali wants to merge 3 commits intoSuiteCRM:hotfixfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use internal(from db field) / user(from form field) datetime to calculate GMT offset
Description
Pass internal/user datetime value to UserTimeZone function. It uses current datetime now, so if you insert/view a datetime in same timezone but different DST, calculated GMT offset is wrong
Motivation and Context
Fix #652
How To Test This
See #652
Types of changes
Final checklist