Skip to content

Update deletion-requests.md #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 23, 2024
Merged

Update deletion-requests.md #4500

merged 7 commits into from
Dec 23, 2024

Conversation

@manashar4
Copy link
Contributor

@manashar4 manashar4 commented Sep 4, 2024

Purpose of this pull request

This pull request...

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 4, 2024
jpipkin1
jpipkin1 reviewed Sep 4, 2024
View reviewed changes
jpipkin1
jpipkin1 reviewed Sep 4, 2024
View reviewed changes
@jpipkin1 jpipkin1 self-requested a review September 4, 2024 15:37
@jpipkin1
Copy link
Collaborator

jpipkin1 commented Sep 10, 2024

@JV0812, could you address the comment above?

#4500 (comment)

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Dec 4, 2024

@JV0812, could you follow up on the comment from @manashar4?

@jpipkin1 jpipkin1 closed this Dec 4, 2024
@jpipkin1 jpipkin1 reopened this Dec 4, 2024
@jpipkin1 jpipkin1 requested a review from amee-sumo as a code owner December 4, 2024 18:30
@kimsauce kimsauce mentioned this pull request Dec 11, 2024
Merged
4 tasks
@JV0812 JV0812 self-assigned this Dec 12, 2024
@jpipkin1
Copy link
Collaborator

jpipkin1 commented Dec 12, 2024

Looks good, @JV0812.

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Dec 20, 2024

@JV0812, can we publish this PR?

@JV0812 JV0812 enabled auto-merge December 23, 2024 06:35
@JV0812 JV0812 added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 273051f Dec 23, 2024
7 checks passed
@JV0812 JV0812 deleted the manashar4-patch-2 branch December 23, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

Assignees

@manashar4 manashar4

@JV0812 JV0812

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@manashar4 @jpipkin1 @JV0812 @kimsauce