-
-
Notifications
You must be signed in to change notification settings - Fork 50
Issue 3655 swift testing part 2 #3663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8cf5e12
to
b259c21
Compare
Not sure what's going on but the CI keeps failing. All tests pass locally but I can reproduce it on Linux in a dev container. The weird thing is that there's no test failure. It's just a script failure:
Investigating. |
We need to drop xcbeautify. It's eating Swift Testing's output, plus Swift Testing has better test reporting, making it pretty much obsolete. The only downside is that until all tests are converted, we'll have the spammier XCTest reporting and no GH test failure reporting. |
Actually, we're way behind the latest release of 2.25.0 and there seems to be an update that handles Swift Testing output. Testing. |
D'oh, Swift Testing is running the tests in parallel by default. That's why this test conversion (the first one that's using the db) is failing in CI. My Xcode scheme was set to running them sequentially, that's why they passed there. I'll set them to run |
This converts
AnalyzeErrorTests
to Swift Testing.It was a quite a bit more involved than expected, because
override func invokeTest
does not (yet) have an equivalent in Swift Testing. This should be possible with Swift 6.1.