Skip to content

Issue 3655 swift testing part 2 #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 15, 2025
Merged

Issue 3655 swift testing part 2 #3663

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c69b9e6
Make top level variables private
finestructure Feb 5, 2025
9a105f8
Convert AnalyzeErrorTests (with lots of issues)
finestructure Feb 6, 2025
720eb87
Add suite trait, replacing invokeTest
finestructure Feb 6, 2025
56efeec
Fix CapturingLogger logLevel handling, add reset()
finestructure Feb 11, 2025
a214de3
Fix typo
finestructure Feb 13, 2025
9d430a3
Passing analyze_refreshCheckout_failed
finestructure Feb 13, 2025
0530768
Passing analyze_updateRepository_invalidPackageCachePath
finestructure Feb 13, 2025
10b362f
Factor out defaultDependencies
finestructure Feb 13, 2025
cc6d54d
Move CapturingLogger out of tests into struct and withApp
finestructure Feb 13, 2025
f24ca37
All AnalyzeErrorTests are passing
finestructure Feb 13, 2025
b259c21
Drop DependenciesTestSupport from package manifest
finestructure Feb 13, 2025
e5c1218
Move withApp to TestSupport
finestructure Feb 14, 2025
0be81a3
Add test-plain without xcbeautify, using it in CI
finestructure Feb 14, 2025
c3664e1
Set tests to run `--no-parallel`
finestructure Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/App/Commands/Analyze.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ extension Analyze {
// 2024-10-05 sas: We need to explicitly weave dependencies into the `transaction` closure, because escaping closures strip them.
// https://github.com/pointfreeco/swift-dependencies/discussions/283#discussioncomment-10846172
// This might not be needed in Vapor 5 / FluentKit 2
// TODO: verify this is still needed once we upgrade to Vapor 5 / FluentKit 2
// TODO: verify if this is still needed once we upgrade to Vapor 5 / FluentKit 2
try await withEscapedDependencies { dependencies in
try await database.transaction { tx in
try await dependencies.yield {
Expand Down
Loading
Loading