Skip to content

Conversation

@Panaetius
Copy link
Member

@Panaetius Panaetius commented Sep 19, 2024

/deploy #notest

@Panaetius
Copy link
Member Author

Panaetius commented Sep 19, 2024

This change is part of the following stack:

Change managed by git-spice.

@leafty
Copy link
Member

leafty commented Oct 3, 2024

Note: This is also implemented for data connectors secrets in #413.

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11211522036

Details

  • 3 of 10 (30.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 90.501%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/storage/db.py 1 8 12.5%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/auth.py 1 89.61%
components/renku_data_services/crc/models.py 1 84.57%
components/renku_data_services/users/db.py 1 94.18%
Totals Coverage Status
Change from base Build 11210177050: -0.06%
Covered Lines: 9546
Relevant Lines: 10548

💛 - Coveralls

@Panaetius Panaetius marked this pull request as ready for review October 7, 2024 07:16
@Panaetius Panaetius requested a review from a team as a code owner October 7, 2024 07:16
@leafty leafty temporarily deployed to renku-ci-ds-415 October 7, 2024 07:22 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Oct 7, 2024

You can access the deployment of this PR at https://renku-ci-ds-415.dev.renku.ch

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change to db.py is good but the schema change is invalid:

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Panaetius Panaetius merged commit 86e03fb into main Oct 7, 2024
5 checks passed
@Panaetius Panaetius deleted the fix/376-unset-cloud-credentials branch October 7, 2024 11:27
@RenkuBot
Copy link
Contributor

RenkuBot commented Oct 7, 2024

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants