-
Notifications
You must be signed in to change notification settings - Fork 2
fix: allow unsetting storage secrets #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Note: This is also implemented for data connectors secrets in #413. |
Pull Request Test Coverage Report for Build 11211522036Details
💛 - Coveralls |
|
You can access the deployment of this PR at https://renku-ci-ds-415.dev.renku.ch |
leafty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change to db.py is good but the schema change is invalid:
e101a26 to
9818304
Compare
leafty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
/deploy #notest