feat: add support for building linux/arm64 images from code #3899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
force-pushed
the
build/support-build-arm
branch
from
f473490 to
d128a09
Compare
leafty
force-pushed
the
leafty/configure-arm-builds
branch
from
2bc60ad to
05ae9e1
Compare
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3899.dev.renku.ch |
ciyer
requested changes
Nov 27, 2025
Contributor
ciyer
left a comment
ciyer
left a comment
There was a problem hiding this comment.
This looks good! One improvement I see being helpful is to have the "Advanced Settings" open initially if the image platform is not the default.
client/src/features/sessionsV2/components/SessionForm/BuilderAdvancedSettings.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add advanced setting to build session environments to run on the
linux/arm64platform. This feature is required to build sessions which will run on arm64 nodes (e.g.daintat CSCS).PR Stack:
/deploy #notest renku=leafty/configure-arm-builds renku-data-services=leafty/feat-resource-class-platforms #extra-values=enableInternalGitlab=false,dataService.imageBuilders.enabled=true,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.builderImage=leafty/test:selector-1763044425287,dataService.imageBuilders.runImage=leafty/test:run-image-1763044425287,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user,dataService.imageBuilders.platformOverrides.linux/arm64.builderImage=salimkayal/test-arm:cuda-selector-builder-0.1.7,dataService.imageBuilders.platformOverrides.linux/arm64.runImage=salimkayal/test-arm:run-cu-0.1.0,dataService.imageBuilders.platformOverrides.linux/arm64.nodeSelector.renku.io/arch=arm64,dataService.imageBuilders.platformOverrides.linux/arm64.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].effect=NoSchedule,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].operator=Equal,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].value=user,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].effect=NoSchedule,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].key=renku.io/arch,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].operator=Equal,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].value=arm64