Skip to content

Conversation

@leafty
Copy link
Member

@leafty leafty commented Nov 17, 2025

Update the session launcher UI to indicate when the container image is not compatible with the resource pool. This feature will help users understand how to configure sessions running on linux/arm64 (e.g. daint at CSCS).

Screenshot 2025-11-28 at 09 51 03

PR Stack:

/deploy #notest renku=leafty/configure-arm-builds renku-data-services=build/support-build-arm #extra-values=enableInternalGitlab=false,dataService.imageBuilders.enabled=true,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.builderImage=leafty/test:selector-1763044425287,dataService.imageBuilders.runImage=leafty/test:run-image-1763044425287,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user,dataService.imageBuilders.platformOverrides.linux/arm64.builderImage=salimkayal/test-arm:cuda-selector-builder-0.1.7,dataService.imageBuilders.platformOverrides.linux/arm64.runImage=salimkayal/test-arm:run-cu-0.1.0,dataService.imageBuilders.platformOverrides.linux/arm64.nodeSelector.renku.io/arch=arm64,dataService.imageBuilders.platformOverrides.linux/arm64.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].effect=NoSchedule,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].operator=Equal,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[0].value=user,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].effect=NoSchedule,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].key=renku.io/arch,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].operator=Equal,dataService.imageBuilders.platformOverrides.linux/arm64.tolerations[1].value=arm64

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3910.dev.renku.ch

@leafty leafty force-pushed the leafty/configure-arm-builds branch from 2bc60ad to 05ae9e1 Compare November 27, 2025 08:08
@leafty leafty force-pushed the leafty/handle-platforms branch from cfaf400 to 464f3e8 Compare November 27, 2025 08:15
Base automatically changed from leafty/configure-arm-builds to build/support-build-arm November 27, 2025 13:21
@leafty leafty force-pushed the leafty/handle-platforms branch from 464f3e8 to 3d30c3e Compare November 28, 2025 08:16
@leafty leafty marked this pull request as ready for review November 28, 2025 08:52
@leafty leafty requested a review from a team as a code owner November 28, 2025 08:52
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks very good!

I'm seeing some confusing behavior when changing the platform, though. Try out this scenario:

  • Create a session launcher/environment and set it to make an amd64 build.
  • (Wait for the image build)
  • Then change the environment to arm64

There is no indication that your environment is out of sync with what will be launched when you push the launch button.

Can this be fixed?

@leafty
Copy link
Member Author

leafty commented Nov 28, 2025

There is no indication that your environment is out of sync with what will be launched when you push the launch button.

If the built image is not compatible, then the badge will show it.

@ciyer
Copy link
Contributor

ciyer commented Nov 28, 2025

If the built image is not compatible, then the badge will show it.

Yes, this is correct, but the issue is that the settings for the environment may be out of sync with what will be launched if the environment settings were changed and the image has not been rebuilt.

@leafty
Copy link
Member Author

leafty commented Nov 28, 2025

Yes, this is correct, but the issue is that the settings for the environment may be out of sync with what will be launched if the environment settings were changed and the image has not been rebuilt.

I don't see any easy way to fix this and I don't want to add too much new UI code for a small use-case (CSCS sessions on arm64). There is a red badge and if users don't understand that it means the session launch will not work, I don't know if they should launch a CSCS session at all.

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leafty leafty merged commit 82551dd into build/support-build-arm Nov 28, 2025
13 checks passed
@leafty leafty deleted the leafty/handle-platforms branch November 28, 2025 13:46
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants