Skip to content

Conversation

@tyler-dane
Copy link
Contributor

@tyler-dane tyler-dane commented Oct 14, 2025

⚠️ Bumps node version from 20 to 24

Closes #692

This is a breaking change for local developers; you will have to switch to node 24 when running compass locally now.

I recommend using nvm to manage your node versions locally. Here's how to bump node version to 24::

tyler@Tylers-MacBook-Pro ‹ feat/1112-playwright ● › : ~/src/switchback/compass
[0] % node -v
v20.14.0

tyler@Tylers-MacBook-Pro ‹ feat/1112-playwright ●● › : ~/src/switchback/compass
[0] % nvm use 24
N/A: version "v24" is not yet installed.

You need to run `nvm install 24` to install and use it.

tyler@Tylers-MacBook-Pro ‹ feat/1112-playwright ● › : ~/src/switchback/compass
[3] % nvm install 24
Downloading and installing node v24.10.0...
Downloading https://nodejs.org/dist/v24.10.0/node-v24.10.0-darwin-arm64.tar.xz...
############################################################################################# 100.0%
Computing checksum with sha256sum
Checksums matched!
Now using node v24.10.0 (npm v11.6.1)

Sets up Playwright

Closes #861 and #1115

Playwright tests should run on every PR now. This just includes one simple test, but now more can be added during normal development

Copilot AI review requested due to automatic review settings October 14, 2025 19:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces end-to-end testing capabilities using Playwright for the project. The changes add comprehensive E2E testing infrastructure to enable automated browser testing of the application's user interface and functionality.

  • Adds Playwright configuration with support for both desktop and mobile Chrome testing
  • Updates Node.js engine requirement to version 24.0.0 and adds Playwright dependency
  • Creates initial E2E test for login page functionality across desktop and mobile viewports
  • Implements GitHub Actions workflow for automated E2E test execution on pull requests

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File Description
playwright.config.ts Configures Playwright test runner with desktop/mobile projects and web server settings
package.json Updates Node.js requirement and adds Playwright dependency with new test script
e2e/login.spec.ts Implements login page tests for desktop terminal and mobile waitlist interfaces
.github/workflows/e2e.yml Sets up CI workflow for automated E2E testing on pull requests

@tyler-dane tyler-dane changed the title Feat/1112 playwright !feat: install playwright and bump node to v24 Oct 14, 2025
Copilot AI review requested due to automatic review settings October 14, 2025 19:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.

@tyler-dane tyler-dane changed the title !feat: install playwright and bump node to v24 !feat: bump node to v24 and install playwright Oct 14, 2025
@tyler-dane tyler-dane changed the title !feat: bump node to v24 and install playwright !feat: bump node to v24 and setup playwright Oct 14, 2025
Copilot AI review requested due to automatic review settings October 14, 2025 20:33
…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings October 14, 2025 21:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings October 14, 2025 21:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings October 14, 2025 21:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Copilot AI review requested due to automatic review settings October 14, 2025 22:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings October 14, 2025 22:11
@tyler-dane tyler-dane marked this pull request as ready for review October 14, 2025 22:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings October 14, 2025 22:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated no new comments.

@tyler-dane tyler-dane changed the title !feat: bump node to v24 and setup playwright feat!: bump node to v24 and setup playwright Oct 14, 2025
@tyler-dane tyler-dane merged commit 36ccde3 into main Oct 14, 2025
6 checks passed
@tyler-dane tyler-dane deleted the feat/1112-playwright branch October 14, 2025 22:29
victor-enogwe pushed a commit that referenced this pull request Oct 24, 2025
* chore: update .gitignore to include Playwright and test report directories

* feat: add end-to-end testing support with Playwright

* feat(e2e): add Playwright configuration and login tests

* feat(e2e): update Node.js version requirement and add E2E workflow

* deps: update yarn.lock

* deps(scripts): update @types/node to version 24.7.2 in package.json and yarn.lock

* chore(github): update Node.js version to 24 in CI workflows

* chore(github): rename test files for clarify

* chore(web): fix webpack URL message

* chore: update playwright and e2e vars

* deps(web): update html-webpack-plugin to version 5.6.4 in package.json and yarn.lock

* fix(web): improve error message for missing GOOGLE_CLIENT_ID in webpack config

* Potential fix for code scanning alert no. 42: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* fix(scripts): update clientId variable

* fix(e2e): simplify e2e test to check for login redirect

* fix(e2e): mock /auth/google response

* fix(e2e): mock auth apis

* fix(e2e): enhance login redirect tests with detailed logging and debugging

* fix(e2e): enhance Playwright config for CI with timeouts and retries

* chore: revert debugging and simplify test

* test(e2e): simplify test

* chore: reduce timeout

* Update e2e/render.spec.ts

Co-authored-by: Copilot <[email protected]>

* Update packages/web/webpack.config.js

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
victor-enogwe pushed a commit that referenced this pull request Oct 24, 2025
* chore: update .gitignore to include Playwright and test report directories

* feat: add end-to-end testing support with Playwright

* feat(e2e): add Playwright configuration and login tests

* feat(e2e): update Node.js version requirement and add E2E workflow

* deps: update yarn.lock

* deps(scripts): update @types/node to version 24.7.2 in package.json and yarn.lock

* chore(github): update Node.js version to 24 in CI workflows

* chore(github): rename test files for clarify

* chore(web): fix webpack URL message

* chore: update playwright and e2e vars

* deps(web): update html-webpack-plugin to version 5.6.4 in package.json and yarn.lock

* fix(web): improve error message for missing GOOGLE_CLIENT_ID in webpack config

* Potential fix for code scanning alert no. 42: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* fix(scripts): update clientId variable

* fix(e2e): simplify e2e test to check for login redirect

* fix(e2e): mock /auth/google response

* fix(e2e): mock auth apis

* fix(e2e): enhance login redirect tests with detailed logging and debugging

* fix(e2e): enhance Playwright config for CI with timeouts and retries

* chore: revert debugging and simplify test

* test(e2e): simplify test

* chore: reduce timeout

* Update e2e/render.spec.ts

Co-authored-by: Copilot <[email protected]>

* Update packages/web/webpack.config.js

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add e2e tests with Playwright Require NodeJS version 24 and pin Yarn version

2 participants