-
Notifications
You must be signed in to change notification settings - Fork 51
feat!: bump node to v24 and setup playwright #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces end-to-end testing capabilities using Playwright for the project. The changes add comprehensive E2E testing infrastructure to enable automated browser testing of the application's user interface and functionality.
- Adds Playwright configuration with support for both desktop and mobile Chrome testing
- Updates Node.js engine requirement to version 24.0.0 and adds Playwright dependency
- Creates initial E2E test for login page functionality across desktop and mobile viewports
- Implements GitHub Actions workflow for automated E2E test execution on pull requests
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playwright.config.ts | Configures Playwright test runner with desktop/mobile projects and web server settings |
| package.json | Updates Node.js requirement and adds Playwright dependency with new test script |
| e2e/login.spec.ts | Implements login page tests for desktop terminal and mobile waitlist interfaces |
| .github/workflows/e2e.yml | Sets up CI workflow for automated E2E testing on pull requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated no new comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated no new comments.
* chore: update .gitignore to include Playwright and test report directories * feat: add end-to-end testing support with Playwright * feat(e2e): add Playwright configuration and login tests * feat(e2e): update Node.js version requirement and add E2E workflow * deps: update yarn.lock * deps(scripts): update @types/node to version 24.7.2 in package.json and yarn.lock * chore(github): update Node.js version to 24 in CI workflows * chore(github): rename test files for clarify * chore(web): fix webpack URL message * chore: update playwright and e2e vars * deps(web): update html-webpack-plugin to version 5.6.4 in package.json and yarn.lock * fix(web): improve error message for missing GOOGLE_CLIENT_ID in webpack config * Potential fix for code scanning alert no. 42: Workflow does not contain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix(scripts): update clientId variable * fix(e2e): simplify e2e test to check for login redirect * fix(e2e): mock /auth/google response * fix(e2e): mock auth apis * fix(e2e): enhance login redirect tests with detailed logging and debugging * fix(e2e): enhance Playwright config for CI with timeouts and retries * chore: revert debugging and simplify test * test(e2e): simplify test * chore: reduce timeout * Update e2e/render.spec.ts Co-authored-by: Copilot <[email protected]> * Update packages/web/webpack.config.js Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Copilot <[email protected]>
* chore: update .gitignore to include Playwright and test report directories * feat: add end-to-end testing support with Playwright * feat(e2e): add Playwright configuration and login tests * feat(e2e): update Node.js version requirement and add E2E workflow * deps: update yarn.lock * deps(scripts): update @types/node to version 24.7.2 in package.json and yarn.lock * chore(github): update Node.js version to 24 in CI workflows * chore(github): rename test files for clarify * chore(web): fix webpack URL message * chore: update playwright and e2e vars * deps(web): update html-webpack-plugin to version 5.6.4 in package.json and yarn.lock * fix(web): improve error message for missing GOOGLE_CLIENT_ID in webpack config * Potential fix for code scanning alert no. 42: Workflow does not contain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix(scripts): update clientId variable * fix(e2e): simplify e2e test to check for login redirect * fix(e2e): mock /auth/google response * fix(e2e): mock auth apis * fix(e2e): enhance login redirect tests with detailed logging and debugging * fix(e2e): enhance Playwright config for CI with timeouts and retries * chore: revert debugging and simplify test * test(e2e): simplify test * chore: reduce timeout * Update e2e/render.spec.ts Co-authored-by: Copilot <[email protected]> * Update packages/web/webpack.config.js Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Copilot <[email protected]>
Closes #692
This is a breaking change for local developers; you will have to switch to node 24 when running compass locally now.
I recommend using
nvmto manage your node versions locally. Here's how to bump node version to 24::Sets up Playwright
Closes #861 and #1115
Playwright tests should run on every PR now. This just includes one simple test, but now more can be added during normal development