-
Notifications
You must be signed in to change notification settings - Fork 51
feat!: bump node to v24 and setup playwright #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
016aee8
chore: update .gitignore to include Playwright and test report direct…
tyler-dane 629c41e
feat: add end-to-end testing support with Playwright
tyler-dane 7beca37
feat(e2e): add Playwright configuration and login tests
tyler-dane f2097da
feat(e2e): update Node.js version requirement and add E2E workflow
tyler-dane af8d448
deps: update yarn.lock
tyler-dane 16d71cb
deps(scripts): update @types/node to version 24.7.2 in package.json a…
tyler-dane 9809ff6
chore(github): update Node.js version to 24 in CI workflows
tyler-dane 37e4a24
chore(github): rename test files for clarify
tyler-dane 4112601
chore(web): fix webpack URL message
tyler-dane b201eed
chore: update playwright and e2e vars
tyler-dane 9b23b09
deps(web): update html-webpack-plugin to version 5.6.4 in package.jso…
tyler-dane 1564e98
fix(web): improve error message for missing GOOGLE_CLIENT_ID in webpa…
tyler-dane 39429a4
Potential fix for code scanning alert no. 42: Workflow does not conta…
tyler-dane 2a313be
fix(scripts): update clientId variable
tyler-dane 063f186
fix(e2e): simplify e2e test to check for login redirect
tyler-dane a459ed2
fix(e2e): mock /auth/google response
tyler-dane 21e8827
fix(e2e): mock auth apis
tyler-dane 278e402
fix(e2e): enhance login redirect tests with detailed logging and debu…
tyler-dane 9af3c98
fix(e2e): enhance Playwright config for CI with timeouts and retries
tyler-dane 0eaaa93
chore: revert debugging and simplify test
tyler-dane 4d93a05
test(e2e): simplify test
tyler-dane 3674606
chore: reduce timeout
tyler-dane cbf7bc5
Update e2e/render.spec.ts
tyler-dane 4753eff
Update packages/web/webpack.config.js
tyler-dane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| e2e: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
| cache: yarn | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile --network-timeout 300000 | ||
|
|
||
| - name: Install Playwright browsers | ||
| run: npx playwright install --with-deps chromium | ||
|
|
||
| - name: Run e2e tests | ||
| env: | ||
| TZ: Etc/UTC | ||
| GOOGLE_CLIENT_ID: test-client-id | ||
| API_BASEURL: http://localhost:3000/api | ||
| API_PORT: 3000 | ||
| run: yarn test:e2e | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { expect, test } from "@playwright/test"; | ||
|
|
||
| test("DOM is not empty", async ({ page }) => { | ||
| await page.goto("/"); | ||
|
|
||
| const html = await page.content(); | ||
| expect(html.length).toBeGreaterThan(0); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { defineConfig, devices } from "@playwright/test"; | ||
|
|
||
| export default defineConfig({ | ||
| testDir: "./e2e", | ||
| timeout: 30_000, | ||
| expect: { | ||
| timeout: 10_000, | ||
| }, | ||
| use: { | ||
| baseURL: "http://localhost:9080", | ||
| trace: "on-first-retry", | ||
| }, | ||
| projects: [ | ||
| { | ||
| name: "chromium-desktop", | ||
| use: { ...devices["Desktop Chrome"] }, | ||
| }, | ||
| { | ||
| name: "chromium-mobile", | ||
| use: { ...devices["Pixel 5"] }, | ||
| }, | ||
| ], | ||
| webServer: { | ||
| command: "yarn dev:web", | ||
| env: { | ||
| NODE_ENV: "test", | ||
| WEB_IS_DEV: "false", | ||
| GOOGLE_CLIENT_ID: "test-client-id", | ||
| API_BASEURL: "http://localhost:3000/api", | ||
| API_PORT: "3000", | ||
| POSTHOG_KEY: "test-posthog-key", | ||
| POSTHOG_HOST: "https://app.posthog.com", | ||
| }, | ||
| port: 9080, | ||
| reuseExistingServer: !process.env.CI, | ||
| }, | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.