feat(web): streamline login for returning users#1167
Merged
tyler-dane merged 11 commits intomainfrom Oct 25, 2025
Merged
Conversation
…ginView for signup tracking
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds signup tracking functionality by introducing a new localStorage flag (HAS_COMPLETED_SIGNUP) that is set when users complete authentication. The LoginView now checks this flag to bypass waitlist status checks for returning users who have already signed up.
Key changes:
- Added
HAS_COMPLETED_SIGNUPstorage key constant - Modified login flows to set the signup completion flag in localStorage
- Updated LoginView to check for prior signup completion before performing waitlist checks
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/src/common/constants/storage.constants.ts | Added new HAS_COMPLETED_SIGNUP key constant |
| packages/web/src/views/Onboarding/steps/oauth/SignInWithGoogle.tsx | Sets signup completion flag after successful Google OAuth |
| packages/web/src/views/Onboarding/steps/mobile/MobileSignIn.tsx | Sets signup completion flag after successful mobile Google sign-in |
| packages/web/src/views/Login/Login.tsx | Checks signup completion flag to bypass waitlist checks for returning users |
| packages/web/src/views/Login/Login.test.tsx | Added localStorage cleanup and fixed test type assertion |
packages/web/src/views/Onboarding/steps/mobile/MobileSignIn.tsx
Outdated
Show resolved
Hide resolved
…ginView for signup tracking
tyler-dane
changed the title
tyler-dane
force-pushed
the
feat/451-signin
branch
from
05a87c4 to
10b6375
Compare
tyler-dane
force-pushed
the
feat/451-signin
branch
from
d7ff1ba to
ecedeab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning users will now be presented with the oauth screen immediately upon session expiration, rather than having to go through the onboarding flow again.
Closes #451