Skip to content

feat(web): streamline login for returning users #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyler-dane merged 11 commits into from
Oct 25, 2025
Merged

feat(web): streamline login for returning users #1167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
abe92dd
feat(web): add HAS_COMPLETED_SIGNUP key to localStorage and update Lo…
tyler-dane Oct 25, 2025
21de560
feat(web): implement useHasCompletedSignup hook and integrate into Lo…
tyler-dane Oct 25, 2025
71bb28e
refactor(web): clean up imports in OnboardingStep component
tyler-dane Oct 25, 2025
e937d3a
test(web): add unit tests for OnboardingFlow component
tyler-dane Oct 25, 2025
b35b310
refactor(web): simplify Onboarding component structure and improve re…
tyler-dane Oct 25, 2025
73c8f35
refactor(web): rename withProvider to withOnboardingProvider for clarity
tyler-dane Oct 25, 2025
ac80173
feat(web): enhance onboarding flow for returning users and add loadin…
tyler-dane Oct 25, 2025
10b6375
feat(backend): include user email in session creation and update auth…
tyler-dane Oct 25, 2025
ecedeab
test(web): remove redundant test for new user signup in LoginView
tyler-dane Oct 25, 2025
4248916
test(web): add unit tests for UserProvider component with PostHog int…
tyler-dane Oct 25, 2025
917044f
refactor(web): remove unnecessary comments in OnboardingFlow component
tyler-dane Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web/src/common/constants/storage.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export const STORAGE_KEYS = {
REMINDER: "compass.reminder",
HAS_COMPLETED_SIGNUP: "compass.auth.hasCompletedSignup",
};
3 changes: 2 additions & 1 deletion packages/web/src/views/Login/Login.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ describe("LoginView", () => {

beforeEach(() => {
jest.clearAllMocks();
localStorage.clear();

// Default mock implementations
mockUsePostHog.mockReturnValue({
Expand Down Expand Up @@ -200,7 +201,7 @@ describe("LoginView", () => {
});

// Restore original location
window.location = originalLocation;
(window as any).location = originalLocation;
});
});
});
16 changes: 15 additions & 1 deletion packages/web/src/views/Login/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useAuthCheck } from "@web/auth/useAuthCheck";
import { AuthApi } from "@web/common/apis/auth.api";
import { WaitlistApi } from "@web/common/apis/waitlist.api";
import { ROOT_ROUTES } from "@web/common/constants/routes";
import { STORAGE_KEYS } from "@web/common/constants/storage.constants";
import { AlignItems, FlexDirections } from "@web/components/Flex/styled";
import { LoginAbsoluteOverflowLoader } from "@web/components/LoginAbsoluteOverflowLoader/LoginAbsoluteOverflowLoader";
import { GoogleButton } from "@web/components/oauth/google/GoogleButton";
Expand Down Expand Up @@ -46,7 +47,17 @@ export const LoginView = () => {
const { isAuthenticated: isAlreadyAuthenticated } = useAuthCheck();

useEffect(() => {
if (window.location.hostname === "localhost") {
const hasCompletedSignup = localStorage.getItem(
STORAGE_KEYS.HAS_COMPLETED_SIGNUP,
);
if (hasCompletedSignup === "true") {
setWaitlistStatus({
isOnWaitlist: true,
isInvited: true,
isActive: true,
});
setFlowStep("waitlistStatusKnown");
} else if (window.location.hostname === "localhost") {
setWaitlistStatus({
isOnWaitlist: true,
isInvited: true,
Expand All @@ -64,6 +75,9 @@ export const LoginView = () => {
onSuccess: async (code) => {
const response = await AuthApi.loginOrSignup(code);

// Set flag to track that user has completed signup
localStorage.setItem(STORAGE_KEYS.HAS_COMPLETED_SIGNUP, "true");

// Identify user in PostHog with email as distinct ID
if (response.email && posthog) {
posthog.identify(response.email, { email: response.email });
Expand Down
5 changes: 5 additions & 0 deletions packages/web/src/views/Onboarding/steps/mobile/MobileSignIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from "react";
import { useNavigate } from "react-router-dom";
import { AuthApi } from "@web/common/apis/auth.api";
import { SyncApi } from "@web/common/apis/sync.api";
import { STORAGE_KEYS } from "@web/common/constants/storage.constants";
import { AbsoluteOverflowLoader } from "@web/components/AbsoluteOverflowLoader";
import { GoogleButton } from "@web/components/oauth/google/GoogleButton";
import { useGoogleLogin } from "@web/components/oauth/google/useGoogleLogin";
Expand All @@ -20,6 +21,10 @@ export const MobileSignIn: React.FC<OnboardingStepProps> = ({
const { login, loading } = useGoogleLogin({
onSuccess: async (code) => {
const result = await AuthApi.loginOrSignup(code);

// Set flag to track that user has completed signup
localStorage.setItem(STORAGE_KEYS.HAS_COMPLETED_SIGNUP, "true");

if (result.isNewUser) {
// Start Google Calendar import in the background
// This allows the import to begin while the user continues through onboarding
Expand Down
5 changes: 5 additions & 0 deletions packages/web/src/views/Onboarding/steps/oauth/SignInWithGoogle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { useNavigate } from "react-router-dom";
import { Key } from "ts-key-enum";
import { AuthApi } from "@web/common/apis/auth.api";
import { SyncApi } from "@web/common/apis/sync.api";
import { STORAGE_KEYS } from "@web/common/constants/storage.constants";
import { AbsoluteOverflowLoader } from "@web/components/AbsoluteOverflowLoader";
import { GoogleButton } from "@web/components/oauth/google/GoogleButton";
import { useGoogleLogin } from "@web/components/oauth/google/useGoogleLogin";
Expand All @@ -21,6 +22,10 @@ export const SignInWithGoogle: React.FC<OnboardingStepProps> = ({
const { login, loading } = useGoogleLogin({
onSuccess: async (code) => {
const result = await AuthApi.loginOrSignup(code);

// Set flag to track that user has completed signup
localStorage.setItem(STORAGE_KEYS.HAS_COMPLETED_SIGNUP, "true");

if (result.isNewUser) {
// Start Google Calendar import in the background
// This allows the import to begin while the user continues through onboarding
Expand Down