🐛 Fix: Get m and m shortcuts working by using correct grid assembly method#244
Merged
tyler-dane merged 4 commits intomainfrom Feb 3, 2025
Merged
🐛 Fix: Get m and m shortcuts working by using correct grid assembly method#244tyler-dane merged 4 commits intomainfrom
m and m shortcuts working by using correct grid assembly method#244tyler-dane merged 4 commits intomainfrom
Conversation
…mprove event assembly
…anize event categorization logic
tyler-dane
force-pushed
the
fix/someday-shortcuts
branch
from
0b1ba86 to
d992505
Compare
tyler-dane
changed the title
m and m shortcuts working by using correct grid assembly method
Rename assembleBaseEvent to _assembleBaseEvent and update event selector imports This makes sure the id value is either populated or undefined, which is needed as part of the new event trigger
tyler-dane
force-pushed
the
fix/someday-shortcuts
branch
from
d992505 to
754a3ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #245 by using the correct grid assembly process, which ensures the id is either undefined or an actual string value. We were previously falling back to an empty string
This pull request includes several updates and refactoring to the event utilities in the calendar application. The changes aim to improve the handling of event assembly and overlapping event adjustments, as well as update related tests and components.
Event Utility Refactoring:
SCHEMA_GRID_EVENT_DEFAULT_POSITIONfromweb.constants.tsand updated related imports accordingly.assembleGridEvent,assembleDefaultEvent, andadjustOverlappingEventsfunctions inevent.util.tsto improve event assembly and overlap adjustments. [1] [2] [3] [4]Test Updates:
event.util.test.tsand added a mock forgetUserIdfunction.Component Updates:
AllDayRowandMainGridcomponents to useassembleDefaultEventinstead ofgetDefaultEventfor creating default events. [1] [2] [3] [4] [5] [6]Hook Updates:
assembleDefaultEventinstead ofgetDefaultEventfor creating default events. [1] [2] [3] [4] [5] [6]These changes enhance the maintainability and functionality of the calendar's event handling system.