feat: SymbolicUtils v4 compatibility (release-v1 backport)#161
Open
MilesCranmerBot wants to merge 18 commits intoSymbolicML:release-v1from
Open
feat: SymbolicUtils v4 compatibility (release-v1 backport)#161MilesCranmerBot wants to merge 18 commits intoSymbolicML:release-v1from
MilesCranmerBot wants to merge 18 commits intoSymbolicML:release-v1from
Conversation
This was referenced Feb 14, 2026
Pull Request Test Coverage Report for Build 22120491282Details
💛 - Coveralls |
Restore index_functions round-trip for custom operators under SymbolicUtils v4.
MilesCranmerBot
force-pushed
the
backport/symbolicutils-v4-release-v1
branch
from
7152b02 to
1a8493a
Compare
Member
|
@codex review |
Contributor
Author
|
Swapped Pushed to the PR branch: 50179f3 (MilesCranmerBot@50179f31). |
Adds SymbolicUtils.term() usage to prevent SUv4 from canonicalizing x*x to x^2 during conversion. This makes the backport behaviorally equivalent to upstream/master. - Import term from SymbolicUtils - Use term(op, ...) for * and + in parse_tree_to_eqs - Use term(*, ...) in multiply_powers to build explicit products - Restore test to check x1*x1 stays as explicit multiplication
MilesCranmerBot
force-pushed
the
backport/symbolicutils-v4-release-v1
branch
2 times, most recently
from
7152b02 to
8a293e6
Compare
JET flagged "local variable may be undefined" in src/precompile.jl when iterating over a Vector of types.\n\nUse a tuple for the type loop and initialize so the value is always defined.
Switch the chainrules NaN-mode regression to call unary test operators through instead of explicit Node constructor, while keeping the test resilient to runtime method-extension timing on Julia 1.12. Also add explicit Node-type sanity checks before gradient evaluation.
Restore the original structure (no helper, no explicit Node construction) but wrap the calls in to avoid world-age issues when installs methods during the same thunk on Julia 1.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of SymbolicUtils v4 support onto
release-v1.Includes:
DynamicExpressionsSymbolicUtilsExtfor SymbolicUtils v4.Local check (Julia 1.10.5, fresh depot):
Pkg.test()passed.