Skip to content

refactor(cluster): remove duplicate cluster types#1206

Open
yewman wants to merge 1 commit intomainfrom
harnew/cluster-refactor
Open

refactor(cluster): remove duplicate cluster types#1206
yewman wants to merge 1 commit intomainfrom
harnew/cluster-refactor

Conversation

@yewman
Copy link
Contributor

@yewman yewman commented Feb 3, 2026

Summary

  • Remove duplicate cluster types -> Consolidate to genesis_config.ClusterType
  • Panics when getting entrypoints or RPC urls for 'development' cluster type.
    • When running with 'development' type we should provide entrypoints and rpc urls through cli or config that make sense instead of relying on inline defaults
  • Remove LocalHost, and Custom cluster types since they are unused. These should be replaced by using 'development' type with appropriate cli or config.

@yewman yewman requested review from dnut and ultd as code owners February 3, 2026 23:24
@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Feb 3, 2026
@yewman yewman changed the base branch from main to harnew/cmd-utils February 3, 2026 23:24
@yewman yewman requested a review from Rexicon226 February 3, 2026 23:26
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/accountsdb/db.zig 88.68% <ø> (ø)
src/core/genesis_config.zig 100.00% <100.00%> (ø)
src/gossip/service.zig 87.00% <ø> (+0.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yewman yewman force-pushed the harnew/cluster-refactor branch from a27be6a to f4c4662 Compare February 4, 2026 19:28
@yewman yewman force-pushed the harnew/cluster-refactor branch from f4c4662 to 37495e4 Compare February 5, 2026 02:25
@yewman yewman force-pushed the harnew/cluster-refactor branch from 37495e4 to 5640919 Compare February 5, 2026 19:12
@yewman yewman force-pushed the harnew/cluster-refactor branch from 5640919 to b9842fc Compare February 10, 2026 02:31
@yewman yewman force-pushed the harnew/cluster-refactor branch from b9842fc to 2358595 Compare February 10, 2026 02:34
@yewman yewman force-pushed the harnew/cluster-refactor branch from 2358595 to 54d076d Compare February 10, 2026 22:01
@yewman yewman force-pushed the harnew/cluster-refactor branch from 54d076d to 66c0af4 Compare February 10, 2026 22:07
Rexicon226
Rexicon226 previously approved these changes Feb 10, 2026
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Feb 10, 2026
@yewman yewman force-pushed the harnew/cluster-refactor branch from 66c0af4 to d38847f Compare February 10, 2026 23:13
@yewman yewman force-pushed the harnew/cluster-refactor branch from d38847f to 68b22c4 Compare February 10, 2026 23:18
@yewman yewman force-pushed the harnew/cluster-refactor branch from 68b22c4 to b045bb2 Compare February 11, 2026 20:23
@yewman yewman force-pushed the harnew/cmd-utils branch 3 times, most recently from cad3928 to d24489b Compare February 13, 2026 17:30
Base automatically changed from harnew/cmd-utils to main February 13, 2026 18:23
@yewman yewman dismissed Rexicon226’s stale review February 13, 2026 18:23

The base branch was changed.

- Merge sig.core.Cluster into ClusterType in genesis_config.zig
- Move entrypoints and RPC URLs to ClusterType methods
- Rename localnet to development to match Agave naming
- Lift cluster config from gossip to top-level Cmd config
- Fix duplicate rpc_client.deinit() call in cmd.zig
@yewman yewman force-pushed the harnew/cluster-refactor branch from b045bb2 to 50c43d8 Compare February 13, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants