perf(replay): prune SlotTracker elements off main thread#1229
Open
perf(replay): prune SlotTracker elements off main thread#1229
Conversation
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pruneNonRootedfunction frees Elements in the SlotTracker older than rooted slot. After a fork converges in replay, this ends up taking hundreds of millis (sometimes 1s+). Moving the element frees off the replay thread brings it down to a few hundred micros.An alternative implementation is to have a dedicated
std.Threadin the SlotTracker itself. Avoids the edits of having to pass down the ThreadPool. But I think it pool will come in handy for other rooting stuff (e.g. runonSlotRootedasynchronously).