Minor fixes #251
Open
Minor fixes #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@ColomboMatte0 could you quickly test the edits? |
casperdcl
reviewed
Jun 27, 2025
| - cil # make synergistic notebooks work | ||
| - astra-toolbox # needed for ct examples | ||
| - scipy | ||
| - scipy>=1.16 |
Member
There was a problem hiding this comment.
We can't do this as it requires python>=3.11
Member
Author
There was a problem hiding this comment.
@casperdcl I took this version by attempting to see when scipy switched to the new structure. Maybe I have the wrong version? (seems unlikely we actually would need python 3.11, as some notebooks have the "new" import already I believe)
Member
Author
|
That's kind of weird. Maybe I saw those deprecation messages then on other systems, not our docker. So, we will need to postpone this. (we could put in some workaround checking scipy version, but that seems overkill) |
KrisThielemans
force-pushed
the
minor_fixes
branch
from
814261b to
6f23b5f
Compare
Member
Author
|
I've rebased this after merging #254 to keep only 1 commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Fixes #245(not anymore after the rebase)