Skip to content

Minor fixes #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor fixes #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:
- numpy
- cil # make synergistic notebooks work
- astra-toolbox # needed for ct examples
- scipy
- scipy>=1.16
Copy link
Member

@casperdcl casperdcl Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this as it requires python>=3.11

Copy link
Member Author

@KrisThielemans KrisThielemans Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casperdcl I took this version by attempting to see when scipy switched to the new structure. Maybe I have the wrong version? (seems unlikely we actually would need python 3.11, as some notebooks have the "new" import already I believe)

- matplotlib
- numba
- llvmlite # numba dependency
Expand Down
2 changes: 1 addition & 1 deletion notebooks/Synergistic/BrainWeb-single_slice_motion.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"from sirf.Utilities import examples_data_path\n",
"from sirf_exercises import exercises_data_path\n",
"import shutil\n",
"from scipy.ndimage.filters import gaussian_filter"
"from scipy.ndimage import gaussian_filter"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion notebooks/Synergistic/MAPEM_Bowsher.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"import shutil\n",
"from tqdm.auto import tqdm, trange\n",
"import time\n",
"from scipy.ndimage.filters import gaussian_filter\n",
"from scipy.ndimage import gaussian_filter\n",
"import sirf.STIR as pet\n",
"from numba import jit\n",
"from sirf_exercises import exercises_working_path\n",
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ widgetsnbextension
deprecation
nodejs
numpy
scipy
scipy>=1.16
matplotlib
numba
llvmlite # numba dependency
Expand Down