Skip read/write buffering for external components#26
Closed
davekeeshan wants to merge 2 commits intoSystemRDL:mainfrom
Closed
Skip read/write buffering for external components#26davekeeshan wants to merge 2 commits intoSystemRDL:mainfrom
davekeeshan wants to merge 2 commits intoSystemRDL:mainfrom
Conversation
Member
|
Thanks for the PR! It looks like this addresses two separate issues: #26 and an unreported bug regarding external blocks with address widths of 1 (or 0?).
|
Author
|
I have opened a new issue #29 to capture the address width issue, if you have an upstream merge that will fix the read/write issue for external components close this PR |
Member
|
#25 was resolved from an upstream merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #25. Read/write-buffering logic is no longer emitted for external components.
Checklist