Skip to content

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 4, 2021

Overview

Create CSS component for "Data List" (borrow and improve similar Portal component).

Issues

Just the component (re-usable styles) for GH-75.

Changes

  • Create new CSS component stylesheet.
  • Import new stylesheet into Core site.css.

Testing

Alternative: To test with a plugin instead of a snippet—or test #308 at the same time—then checkout branch task/GH-75-styles--GH-75-plugin instead.

  1. If you do not have a CMS environment, then prepare one with Wiki: Test CMS Changes.
  2. Checkout this branch.
  3. Add new snippet to test page.
  4. Create Snippet plugin with:
  5. Test that the following is rendered:
    • With page template "Fullwidth" (fullwidth.html), see

      several lists and tables with different layouts (toggle for screenshot)

      GH-75 - Test via Snippet

Screenshots

Truncation Requirements Not Met By Layout

Notice: The orange and blue box descriptions are mismatched. Just notice that "Truncate Values" headings are the only sections that allow truncation of values.

Subject Firefox Chromium
D. Lists GH-75 - D Lists - Firefox GH-75 - D Lists - Chromium
Tables GH-75 - Tables - Firefox GH-75 - Tables - Chromium

Truncation Requirements (Artificially) Met by Layout

I both narrowed screen and increased html font-size to 500% and 800% to achieve this layout.

Subject Firefox Chromium Notes
Horizontal GH-75 - D Lists (Horz) - Narrow - Firefox GH-75 - D Lists (Horz) - Narrow - Chromium These are edge cases¹, so everything need not be legible.
The vert. layouts don't need truncation at this screen width and font size.
Firefox supports truncation via character (":"); Chromium does not.
Vertical GH-75 - D Lists (Vert) - Narrow - Firefox GH-75 - D Lists (Vert) - Narrow - Chromium Text "_____" was appended to force truncation.
Firefox supports truncation via character (":"); Chromium does not.

¹ Truncation for horizontal layout is an edge case because: (a) this layout should be used only when enough space is available; (b) when space is not available, responsive design (styles outside this component) should change the surrounding layout so space is available.

- Replicate post-key colon with space for tables.
- Replace implicit truncation with modifier `should-truncate-values`.
- Comment on Firefox font alignment caveat.
@wesleyboar wesleyboar changed the title GH-75: Data List - Styles GH-75: Data List - Styles / Component Aug 4, 2021
@wesleyboar wesleyboar marked this pull request as ready for review August 4, 2021 16:22
@wesleyboar wesleyboar linked an issue Aug 5, 2021 that may be closed by this pull request
@wesleyboar wesleyboar requested a review from iamthatian August 6, 2021 01:16
@wesleyboar wesleyboar mentioned this pull request Aug 7, 2021
2 tasks
@wesleyboar wesleyboar added the priority ━ Medium priority label Aug 8, 2021
Copy link
Contributor

@iamthatian iamthatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

@wesleyboar wesleyboar merged commit 476deda into main Aug 9, 2021
@wesleyboar wesleyboar deleted the task/GH-75-styles branch August 9, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority ━ Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Data List" Table (for System Specs) - Styles & Plugin

3 participants