Skip to content

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 30, 2020

Overview:

New component to:

PR Status:

  • Ready.

Related Jira tickets:

Summary of Changes:

  • Add new component.
  • Allow composes to pass CSS linter.

Testing Steps:

  1. Open. UI Patterns.
  2. View new "DescriptionList" in different browsers.

UI Photos:

The DL Component All Bells   Whistles

P.S. I found no discernible difference between browsers. 2021-08: I found a discernible difference. Firefox supports truncation via character (like ":"), but other browsers do not. This caveat is mentioned on TACC/Core-CMS#305.

Notes:

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #116 into master will increase coverage by 0.07%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   55.02%   55.10%   +0.07%     
==========================================
  Files         220      222       +2     
  Lines        7767     7785      +18     
  Branches     1081     1083       +2     
==========================================
+ Hits         4274     4290      +16     
- Misses       3289     3291       +2     
  Partials      204      204              
Flag Coverage Δ
#javascript 54.81% <88.88%> (+0.28%) ⬆️
#unittests 55.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/components/UIPatterns/UIPatterns.js 0.00% <ø> (ø)
...tternsDescriptionList/UIPatternsDescriptionList.js 33.33% <33.33%> (ø)
...ponents/_common/DescriptionList/DescriptionList.js 100.00% <100.00%> (ø)

@wesleyboar wesleyboar mentioned this pull request Jul 30, 2020
3 tasks
@wesleyboar
Copy link
Member Author

I keep getting an e-mail reporting Client Side Unit Tests failure. I call BS on CodeCov… it won't load the log and local npm test runs shows all passed.

Copy link
Contributor

@jchuahtacc jchuahtacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can't wait to use it.

@wesleyboar wesleyboar merged commit 45157f9 into master Jul 31, 2020
@wesleyboar wesleyboar deleted the task/FP-557-new-dl-ui-component branch July 31, 2020 15:30
@wesleyboar wesleyboar changed the title FP-557: New <dl> Component FP-557: New <dl> (Description/Definition List) Component Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants