-
Notifications
You must be signed in to change notification settings - Fork 0
FP-557: New <dl> (Description/Definition List) Component
#116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 55.02% 55.10% +0.07%
==========================================
Files 220 222 +2
Lines 7767 7785 +18
Branches 1081 1083 +2
==========================================
+ Hits 4274 4290 +16
- Misses 3289 3291 +2
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I keep getting an e-mail reporting Client Side Unit Tests failure. I call BS on CodeCov… it won't load the log and local |
jchuahtacc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can't wait to use it.
<dl> Component<dl> (Description/Definition List) Component
Overview:
New component to:
#cep-designthread)PR Status:
Related Jira tickets:
Summary of Changes:
composesto pass CSS linter.Testing Steps:
UI Photos:
P.S. I found no discernible difference between browsers. 2021-08: I found a discernible difference. Firefox supports truncation via character (like ":"), but other browsers do not. This caveat is mentioned on TACC/Core-CMS#305.
Notes: