Skip to content

Conversation

@WeeJean
Copy link
Contributor

@WeeJean WeeJean commented Dec 17, 2025

Part of #13324

Description

This PR creates the SQL-based PageObject for the InstructorCoursesPage to support the ongoing migration to the SQL backend.

I have implemented InstructorCoursesPageSql.java, mirroring the logic of the existing InstructorCoursesPage.java but adapted to interact with SQL entities.

Changes

  • Created: InstructorCoursesPageSql in teammates.e2e.pageobjects.
  • Entity Migration: Updated methods to accept teammates.storage.sqlentity.Course instead of CourseAttributes.
  • ID Handling: Used course.getId() as the SQL entity retains the String-based ID as the primary key.
  • Test Library: Updated assertions to use JUnit 5 (org.junit.jupiter.api.Assertions) to align with modern project standards.

Verification

  • Verified syntax and imports by running ./gradlew compileTestJava.
  • Manually verified that logic (e.g. iterating through lists, checking table values) matches the original InstructorCoursesPage.java implementation.

@DhiraPT DhiraPT self-requested a review December 17, 2025 17:46
Copy link
Contributor

@DhiraPT DhiraPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DhiraPT DhiraPT merged commit 6b6909f into TEAMMATES:master Jan 15, 2026
11 checks passed
@samuelfangjw samuelfangjw added this to the V9.0.0-beta.7 milestone Jan 25, 2026
@samuelfangjw samuelfangjw added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 25, 2026
@samuelfangjw samuelfangjw assigned DhiraPT and unassigned WeeJean Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c.Task Other non-user-facing works, e.g. refactoring, adding tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants