[TASK] Migrate backport to shared reusable workflow#6414
[TASK] Migrate backport to shared reusable workflow#6414CybotTM wants to merge 0 commit intoTYPO3-Documentation:mainfrom
Conversation
|
(Please note this is a POC we should not merge as-is, because we'd first have to import the referenced repo into our own maintenance scope. Thanks a lot, this is very helpful for discussion!) |
|
@CybotTM thanks for your work. Could we put the into https://github.com/TYPO3-Documentation/t3docs-ci-deploy? it is already the repository for "Build and Deployment Pipelines". |
|
@linawolf, yes of course! |
Add centralized, reusable GitHub Actions workflows that can be called by repositories across the TYPO3-Documentation organization: - backport.yml: Backport merged PRs via korthout/backport-action - docs-render.yml: Documentation rendering check - php-quality.yml: Code quality (CS Fixer, PHPStan, XML lint) - php-tests.yml: PHP test matrix (unit + integration) All actions are SHA-pinned. Reusable workflows execute in this repo's context, so only this repo's action allow-list needs maintenance. Ref: TYPO3-Documentation/TYPO3CMS-Reference-CoreApi#6414
|
@linawolf like this TYPO3-Documentation/t3docs-ci-deploy#56 ? |
Add centralized, reusable GitHub Actions workflows that can be called by repositories across the TYPO3-Documentation organization: - backport.yml: Backport merged PRs via korthout/backport-action - docs-render.yml: Documentation rendering check - php-quality.yml: Code quality (CS Fixer, PHPStan, XML lint) - php-tests.yml: PHP test matrix (unit + integration) All actions are SHA-pinned. Reusable workflows execute in this repo's context, so only this repo's action allow-list needs maintenance. Ref: TYPO3-Documentation/TYPO3CMS-Reference-CoreApi#6414
|
Updated for merged TYPO3-Documentation/t3docs-ci-deploy#56 |
7e42ec5 to
87fd201
Compare
|
I moved your actions to Repo https://github.com/TYPO3-Documentation/.github as suggested by @jaapio and tried out using it like https://github.com/TYPO3-Documentation/TYPO3CMS-Tutorial-GettingStarted/blob/main/.github/workflows/backport.yml but did not get it to working yet. I would suggest we work on that repo as it is smaller and has less changes and trying out workflows there does not influence our daily work so much. After we have successfully tested the workflow we can try it out here |
|
did you notice this comment:
|
|
Let us continue in https://github.com/TYPO3-Documentation/TYPO3CMS-Tutorial-GettingStarted please. The repository we are currently in is to much frequented for experiments. Also, the reusable actions where moved to TYPO3-Documentation/.github |
ac34998 to
6479c1f
Compare
6479c1f to
97ef974
Compare
Problem
The backport workflow is currently inlined in each repo with identical configuration. When
m-kuhn/backport@30b6e83broke (missingdist/index.js), each repo had to be fixed individually. 7 repos still use the broken action:CoreApi was already fixed (migrated to
korthout/backport-action), but the workflow is still inlined.Solution
Replace the inline workflow with a call to the shared reusable workflow from
TYPO3-Documentation/.github, the org's community health repository. This wrapskorthout/backport-actionand is automatically accessible to all repos in the org without allow-list changes.Before/After
Before (22 lines, inline, maintained per-repo):
After (5 lines, shared, maintained centrally):
Benefits
.githubrepo is the org community health repo, automatically trusted by all org reposStatus
Same change needed in 7 other repos. Companion PRs:
Dependencies and merge order
reusable-backport.ymlwhich already exists on.githubmain