[TASK] Assign DataHandler's property copyTree only if the property exists
#689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is related to https://review.typo3.org/c/Packages/TYPO3.CMS/+/91281, so we should wait until the change stabilizes to then merge both in one go. |
lolli42
reviewed
Nov 23, 2025
| message: '#^Call to function property_exists\(\) with TYPO3\\CMS\\Core\\DataHandling\\DataHandler and ''copyTree'' will always evaluate to true\.$#' | ||
| identifier: function.alreadyNarrowedType | ||
| count: 1 | ||
| path: ../../Classes/Core/Functional/Framework/DataHandling/Scenario/DataHandlerWriter.php |
Member
There was a problem hiding this comment.
not 100% sure, but that may fail when the core patch is merged.
lolli42
approved these changes
Nov 23, 2025
Member
|
since the core patch will probably make it, and the change itself here is ok even if the property in DH is kept, i'm going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.