Skip to content

[TASK] Assign DataHandler's property copyTree only if the property exists #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lolli42 merged 2 commits into from
Nov 23, 2025
Merged

[TASK] Assign DataHandler's property copyTree only if the property exists #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
770ccc9
[TASK] Assign DataHandler's property `copyTree` only if the property …
dawind Oct 28, 2025
4760644
Merge branch 'main' into task/copy
lolli42 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Build/phpstan/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ parameters:
count: 1
path: ../../Classes/Core/Functional/Framework/Constraint/RequestSection/HasRecordConstraint.php

-
message: '#^Call to function property_exists\(\) with TYPO3\\CMS\\Core\\DataHandling\\DataHandler and ''copyTree'' will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: ../../Classes/Core/Functional/Framework/DataHandling/Scenario/DataHandlerWriter.php
Copy link
Member

@lolli42 lolli42 Nov 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure, but that may fail when the core patch is merged.


-
message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
identifier: staticMethod.alreadyNarrowedType
Expand Down
2 changes: 1 addition & 1 deletion Classes/Core/Functional/Framework/DataHandling/ActionService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ protected function createDataHandler(): DataHandler
{
$this->dataHandler = GeneralUtility::makeInstance(DataHandler::class);
$backendUser = $this->getBackendUser();
if (isset($backendUser->uc['copyLevels'])) {
if (isset($backendUser->uc['copyLevels']) && property_exists($this->dataHandler, 'copyTree')) {
$this->dataHandler->copyTree = $backendUser->uc['copyLevels'];
}
return $this->dataHandler;
Expand Down
2 changes: 1 addition & 1 deletion Classes/Core/Functional/Framework/DataHandling/Scenario/DataHandlerWriter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ final public function __construct(
public static function withBackendUser(BackendUserAuthentication $backendUser): self
{
$dataHandler = GeneralUtility::makeInstance(DataHandler::class);
if (isset($backendUser->uc['copyLevels'])) {
if (isset($backendUser->uc['copyLevels']) && property_exists($dataHandler, 'copyTree')) {
$dataHandler->copyTree = $backendUser->uc['copyLevels'];
}
return new static($dataHandler, $backendUser);
Expand Down