-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: override h3 in nitro-v2-plugin to h3@v2 #5376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
this fixes an install issue with bun where, without using isolated installs, only a single version of h3 was installed (in this case, v1) we still install v1 of h3 as the `h3-v1` alias and redirect nitropack to that via the resolveId rollup plugin
WalkthroughAdds package manager pins for transitive dependency h3 to version 2.0.0-beta.5 in packages/nitro-v2-vite-plugin/package.json via overrides and resolutions entries. No source code or runtime logic changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
View your CI Pipeline Execution ↗ for commit 40962b4
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/nitro-v2-vite-plugin/package.json
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace:* protocol for internal dependencies in package.json files
Files:
packages/nitro-v2-vite-plugin/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
"overrides": { | ||
"h3": "2.0.0-beta.5" | ||
}, | ||
"resolutions": { | ||
"h3": "2.0.0-beta.5" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move pin to pnpm.overrides
for pnpm installs.
Our workspace installs with pnpm, which ignores the npm-level "overrides"
field. The pin should live under "pnpm": { "overrides": { ... } }
(and keep "resolutions"
for Yarn) so pnpm actually forces [email protected]
. As written, the pin is not applied and the Bun/pnpm install issue remains.
- "overrides": {
- "h3": "2.0.0-beta.5"
- },
+ "pnpm": {
+ "overrides": {
+ "h3": "2.0.0-beta.5"
+ }
+ },
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"overrides": { | |
"h3": "2.0.0-beta.5" | |
}, | |
"resolutions": { | |
"h3": "2.0.0-beta.5" | |
}, | |
"pnpm": { | |
"overrides": { | |
"h3": "2.0.0-beta.5" | |
} | |
}, | |
"resolutions": { | |
"h3": "2.0.0-beta.5" | |
}, |
🤖 Prompt for AI Agents
In packages/nitro-v2-vite-plugin/package.json around lines 66 to 71, the current
top-level "overrides" entry is ignored by pnpm so [email protected] is not forced;
move that pin into the pnpm-specific field: add a "pnpm": { "overrides": { "h3":
"2.0.0-beta.5" } } entry in package.json (keep the existing "resolutions" for
Yarn), and remove or keep the top-level "overrides" only if you want npm
consumers to also see it—ensure the version string matches exactly and run pnpm
install to verify pnpm applies the override.
this fixes an install issue with bun where, without using isolated installs, only a single version of h3 was installed (in this case, v1)
we still install v1 of h3 as the
h3-v1
alias and redirect nitropack to that via the resolveId rollup pluginSummary by CodeRabbit