Skip to content

Conversation

schiller-manuel
Copy link
Contributor

@schiller-manuel schiller-manuel commented Oct 5, 2025

this fixes an install issue with bun where, without using isolated installs, only a single version of h3 was installed (in this case, v1)

we still install v1 of h3 as the h3-v1 alias and redirect nitropack to that via the resolveId rollup plugin

Summary by CodeRabbit

  • Chores
    • Pinned a transitive dependency (h3) to a specific version to ensure consistent installs across environments and prevent unexpected upstream changes.
    • Improves build determinism and installation reliability without altering features or behavior.
    • No changes to user-facing APIs, configuration, or runtime functionality; this is a stability-focused maintenance update for development and packaging workflows.

this fixes an install issue with bun where, without using isolated installs, only a single version of h3 was installed (in this case, v1)

we still install v1 of h3 as the `h3-v1` alias and redirect nitropack to that via the resolveId rollup plugin
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Walkthrough

Adds package manager pins for transitive dependency h3 to version 2.0.0-beta.5 in packages/nitro-v2-vite-plugin/package.json via overrides and resolutions entries. No source code or runtime logic changes.

Changes

Cohort / File(s) Summary of Changes
Dependency resolution adjustments
packages/nitro-v2-vite-plugin/package.json
Added "overrides" and "resolutions" entries pinning "h3": "2.0.0-beta.5" to control transitive dependency resolution during install/hoisting. No other dependency fields changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A nibble of deps, a hop in the grass,
I pin little h3 so builds smoothly pass.
No code did I tweak, no logic to mend—
Just tidy the roots where packages blend.
Thump-thump, ship fast—your bunny friend. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely describes the primary change of the pull request, which is overriding the h3 dependency in the nitro-v2-plugin to version 2, matching the edits to the package.json dependency controls.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch h3-bun

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

nx-cloud bot commented Oct 5, 2025

View your CI Pipeline Execution ↗ for commit 40962b4

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 2m 59s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-05 19:57:55 UTC

Copy link

pkg-pr-new bot commented Oct 5, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5376

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5376

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5376

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5376

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5376

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5376

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5376

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5376

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5376

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5376

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5376

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5376

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5376

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5376

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5376

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5376

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5376

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5376

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5376

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5376

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5376

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5376

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5376

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5376

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5376

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5376

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5376

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5376

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5376

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5376

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5376

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5376

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5376

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5376

commit: 40962b4

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e94e9c7 and 40962b4.

📒 Files selected for processing (1)
  • packages/nitro-v2-vite-plugin/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Use workspace:* protocol for internal dependencies in package.json files

Files:

  • packages/nitro-v2-vite-plugin/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Preview
  • GitHub Check: Test

Comment on lines +66 to +71
"overrides": {
"h3": "2.0.0-beta.5"
},
"resolutions": {
"h3": "2.0.0-beta.5"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Move pin to pnpm.overrides for pnpm installs.

Our workspace installs with pnpm, which ignores the npm-level "overrides" field. The pin should live under "pnpm": { "overrides": { ... } } (and keep "resolutions" for Yarn) so pnpm actually forces [email protected]. As written, the pin is not applied and the Bun/pnpm install issue remains.

-  "overrides": {
-    "h3": "2.0.0-beta.5"
-  },
+  "pnpm": {
+    "overrides": {
+      "h3": "2.0.0-beta.5"
+    }
+  },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"overrides": {
"h3": "2.0.0-beta.5"
},
"resolutions": {
"h3": "2.0.0-beta.5"
},
"pnpm": {
"overrides": {
"h3": "2.0.0-beta.5"
}
},
"resolutions": {
"h3": "2.0.0-beta.5"
},
🤖 Prompt for AI Agents
In packages/nitro-v2-vite-plugin/package.json around lines 66 to 71, the current
top-level "overrides" entry is ignored by pnpm so [email protected] is not forced;
move that pin into the pnpm-specific field: add a "pnpm": { "overrides": { "h3":
"2.0.0-beta.5" } } entry in package.json (keep the existing "resolutions" for
Yarn), and remove or keep the top-level "overrides" only if you want npm
consumers to also see it—ensure the version string matches exactly and run pnpm
install to verify pnpm applies the override.

@schiller-manuel schiller-manuel marked this pull request as draft October 5, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant