Skip to content

fix: override h3 in nitro-v2-plugin to h3@v2 #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Draft

fix: override h3 in nitro-v2-plugin to h3@v2 #5376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/nitro-v2-vite-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@
"pathe": "^2.0.3",
"h3-v1": "npm:h3@^1.15.4"
},
"overrides": {
"h3": "2.0.0-beta.5"
},
"resolutions": {
"h3": "2.0.0-beta.5"
},
Comment on lines +66 to +71
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Move pin to pnpm.overrides for pnpm installs.

Our workspace installs with pnpm, which ignores the npm-level "overrides" field. The pin should live under "pnpm": { "overrides": { ... } } (and keep "resolutions" for Yarn) so pnpm actually forces [email protected]. As written, the pin is not applied and the Bun/pnpm install issue remains.

-  "overrides": {
-    "h3": "2.0.0-beta.5"
-  },
+  "pnpm": {
+    "overrides": {
+      "h3": "2.0.0-beta.5"
+    }
+  },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"overrides": {
"h3": "2.0.0-beta.5"
},
"resolutions": {
"h3": "2.0.0-beta.5"
},
"pnpm": {
"overrides": {
"h3": "2.0.0-beta.5"
}
},
"resolutions": {
"h3": "2.0.0-beta.5"
},
🤖 Prompt for AI Agents 
In packages/nitro-v2-vite-plugin/package.json around lines 66 to 71, the current
top-level "overrides" entry is ignored by pnpm so [email protected] is not forced;
move that pin into the pnpm-specific field: add a "pnpm": { "overrides": { "h3":
"2.0.0-beta.5" } } entry in package.json (keep the existing "resolutions" for
Yarn), and remove or keep the top-level "overrides" only if you want npm
consumers to also see it—ensure the version string matches exactly and run pnpm
install to verify pnpm applies the override.

"peerDependencies": {
"vite": ">=7.0.0"
}
Expand Down
Loading