Support RTL usernames in comment header#12188
Conversation
ShareASmile
added
bug
|
Example Video: https://www.youtube.com/watch?v=_t69RAfpAGY |
|
We should make sure the @ stays in front of the username, right now it’s pushed all the way to the right. |
github-actions
bot
added
size/small
|
I removed the formatting changes from the commit, since they obscured the logic too much. |
|
I switched the code around a little, now it looks reasonable to me:
|
The `@` gets added by the youtube API and thus is a fixed member of the username, so we do some simple detection logic to handle that case (otherwise the `@` will be at the right side of a RTL username, which is different of how Youtube displays these usernames in the browser). Fixes TeamNewPipe#12141
|
|
Thank you! Great change |
AudricV
changed the title
|
I kept the "@" on the right side because that's how RTL languages are read—it felt odd to start with "@" and then jump to the end of the username. I followed how YouTube does it too ( {rtl_username}@ ). |
|
@VougJo23 Oh, wait, maybe I didn’t understand it then For me the Youtube browser app displays it like this: Maybe where the @ is put depends on your locale in general?? (edit: also sorry if I accidentally screenshot a racist comment or something, I don’t speak Arabic obviously :P) |
|
Sorry btw for taking a potentially disturbing video of a current conflict as an example :( |
From the discussion in TeamNewPipe#12188 it reads more natural for RTL readers.
Had to make some adjustments to make #12188 work
fix: support RTL usernames in comment header
From the discussion in TeamNewPipe#12188 it reads more natural for RTL readers.
fix: support RTL usernames in comment header
3 participants
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
After:
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence