Skip to content

Conversation

@Isaac-75
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Added boolean "notificationsAccepted" field in the App class
  • Added getNotificationsAccepted() method, which returns the field
  • Added setNotificationsAccepted() method, which sets the field to true
  • Incorporated methods in the checkPostNotificationsPermission() method within the PermissionHelper class

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 18, 2025
@TobiGr TobiGr added the bug Issue is related to a bug label Oct 23, 2025
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"allow NewPipe to send you notification" message appears again when changing from portait to landscape view

2 participants