Skip to content

Notifications are no longer requested again after rotating the phone #12716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
+17 −3
Merged

Notifications are no longer requested again after rotating the phone #12716

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4e6e4d
Notifications are no longer requested again after rotating the phone
Isaac-75 Oct 18, 2025
88eb32b
moved field as requested
Isaac-75 Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/src/main/java/org/schabi/newpipe/App.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,21 @@ public class App extends Application {

private boolean isFirstRun = false;
private static App app;
private boolean notificationsRequested = false;

@NonNull
public static App getApp() {
return app;
}

public boolean getNotificationsRequested() {
return notificationsRequested;
}

public void setNotificationsRequested() {
notificationsRequested = true;
}

@Override
protected void attachBaseContext(final Context base) {
super.attachBaseContext(base);
Expand Down
10 changes: 7 additions & 3 deletions app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import androidx.core.app.ActivityCompat;
import androidx.core.content.ContextCompat;

import org.schabi.newpipe.App;
import org.schabi.newpipe.R;
import org.schabi.newpipe.settings.NewPipeSettings;

Expand Down Expand Up @@ -89,9 +90,12 @@ public static boolean checkPostNotificationsPermission(final Activity activity,
&& ContextCompat.checkSelfPermission(activity,
Manifest.permission.POST_NOTIFICATIONS)
!= PackageManager.PERMISSION_GRANTED) {
ActivityCompat.requestPermissions(activity,
new String[] {Manifest.permission.POST_NOTIFICATIONS}, requestCode);
return false;
if (!App.getApp().getNotificationsRequested()) {
ActivityCompat.requestPermissions(activity,
new String[]{Manifest.permission.POST_NOTIFICATIONS}, requestCode);
App.getApp().setNotificationsRequested();
return false;
}
}
return true;
}
Expand Down