Added support for faulty temperature sensor.#109
Merged
SeongGino merged 2 commits intoTeamOpenFIRE:OpenFIRE-devfrom Jan 16, 2026
Merged
Added support for faulty temperature sensor.#109SeongGino merged 2 commits intoTeamOpenFIRE:OpenFIRE-devfrom
SeongGino merged 2 commits intoTeamOpenFIRE:OpenFIRE-devfrom
Conversation
Member
|
Will just await the prereq boards bump before pulling. |
Member
|
Everything builds and looks fine here, will wait on the dependent firmware change to get pulled. 🙂 |
Member
|
Prereq finished, ready for pull |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds improved error handling for temperature sensor faults in the serial port data processing logic. The main change is the detection of a specific error value and updating the UI accordingly to alert the user.
Temperature sensor error handling:
guiWindow::serialPort_readyRead()(src/appmainwindow.cpp), added logic to check forOF_Const::TEMPERATURE_SENSOR_ERROR_VALUEand display a "Temperature: FAULT" message with a red background on thetmp36Labelto indicate a sensor error.ATTENTION:
This PR requires the following PR merged before (will update submodule once boards is merged):
TeamOpenFIRE/OpenFIRE-Boards#11