Added common temperature sensor error value.#11
Merged
SeongGino merged 1 commit intoTeamOpenFIRE:mainfrom Jan 13, 2026
Merged
Conversation
This was referenced Jan 12, 2026
Merged
SeongGino
approved these changes
Jan 13, 2026
Member
SeongGino
left a comment
SeongGino
left a comment
There was a problem hiding this comment.
Just a single line, not really seeing any harm with that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new constant to the
OF_Constclass inOpenFIREshared.hto represent a specific error value for temperature sensor faults or disconnections.Sensor error handling:
TEMPERATURE_SENSOR_ERROR_VALUEconstant toOF_Constto indicate an ADC reading that signals a temperature sensor fault or disconnection.ATTENTION:
This PR is required for other PRs in firmware and app repo:
TeamOpenFIRE/OpenFIRE-Firmware#141
TeamOpenFIRE/OpenFIRE-App#109