Skip to content

Conversation

@rshrirohit
Copy link
Collaborator

@rshrirohit rshrirohit commented Aug 19, 2025

JIRA link

TD-5339

Description

This PR introduces the "Self Assessment Process Agreement" functionality.

Key Changes

  • Added DB Column:
    SelfAssessmentProcessAgreed - nullable
  • Self Assessment Agreement Step:
    Added a new step in the self-assessment process where users must review and agree to the process agreement before continuing.
  • UI Updates:
    Introduced a new UI component/page/model for displaying the process agreement and capturing user consent.
  • Backend Support:
    Updated backend logic to track user agreement status and enforce the process agreement step as mandatory.
  • Validation:
    Users cannot proceed with their self assessment until they explicitly accept the agreement.
  • Unit/Integration Tests:
    Added/updated tests to cover the new agreement step and ensure robust validation.

Screenshots

image image image image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@rshrirohit rshrirohit marked this pull request as ready for review August 19, 2025 07:20
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Selfassessment.cs - I think it would be good if we moved code changes (line 78-86) after line number 69.

@sherif-olaboye
Copy link
Contributor

The PR looks ok

@model SelfAssessmentProcessViewModel
@{
var errorHasOccurred = !ViewData.ModelState.IsValid;
ViewData["Title"] = (errorHasOccurred ? "Error: " : "") + "Agree To Process";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maybe try to do something cleaner here, maybe we can set this through this view's specific controller method. We can assign values technically on the view pages but they should be simpler and not involving a ternary operation.

Copy link
Contributor

@ABSinhaa ABSinhaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good other than some comments made on the specific parts.

@rshrirohit rshrirohit merged commit 618ee37 into DLS-Release-v1.2.2 Aug 21, 2025
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Feature/TD-5339-SelfAssessmentProcessAgreement branch August 21, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants