- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
TD-5339 Self Assessment Process Agreement #3352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD-5339 Self Assessment Process Agreement #3352
Conversation
        
          
                ...LearningSolutions.Web/Views/LearningPortal/SelfAssessments/AgreeSelfAssessmentProcess.cshtml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Selfassessment.cs - I think it would be good if we moved code changes (line 78-86) after line number 69.
        
          
                DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/Controllers/LearningPortalController/SelfAssessment.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | The PR looks ok | 
| @model SelfAssessmentProcessViewModel | ||
| @{ | ||
| var errorHasOccurred = !ViewData.ModelState.IsValid; | ||
| ViewData["Title"] = (errorHasOccurred ? "Error: " : "") + "Agree To Process"; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should maybe try to do something cleaner here, maybe we can set this through this view's specific controller method. We can assign values technically on the view pages but they should be simpler and not involving a ternary operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good other than some comments made on the specific parts.
JIRA link
TD-5339
Description
This PR introduces the "Self Assessment Process Agreement" functionality.
Key Changes
SelfAssessmentProcessAgreed - nullable
Added a new step in the self-assessment process where users must review and agree to the process agreement before continuing.
Introduced a new UI component/page/model for displaying the process agreement and capturing user consent.
Updated backend logic to track user agreement status and enforce the process agreement step as mandatory.
Users cannot proceed with their self assessment until they explicitly accept the agreement.
Added/updated tests to cover the new agreement step and ensure robust validation.
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: