- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
TD-5339 Self Assessment Process Agreement #3352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            rshrirohit
  merged 3 commits into
  DLS-Release-v1.2.2
from
Develop/Feature/TD-5339-SelfAssessmentProcessAgreement
  
      
      
   
  Aug 21, 2025 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            3 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
        
          
          
            18 changes: 18 additions & 0 deletions
          
          18 
        
  DigitalLearningSolutions.Data.Migrations/202508190845_AddSelfAssessmentProcessAgreed .cs
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| namespace DigitalLearningSolutions.Data.Migrations | ||
| { | ||
| using FluentMigrator; | ||
|  | ||
| [Migration(202508190845)] | ||
| public class AddSelfAssessmentProcessAgreed : Migration | ||
| { | ||
| public override void Up() | ||
| { | ||
| Alter.Table("CandidateAssessments").AddColumn("SelfAssessmentProcessAgreed").AsDateTime().Nullable(); | ||
| } | ||
|  | ||
| public override void Down() | ||
| { | ||
| Delete.Column("SelfAssessmentProcessAgreed").FromTable("CandidateAssessments"); | ||
| } | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            18 changes: 18 additions & 0 deletions
          
          18 
        
  ...Solutions.Web/ViewModels/LearningPortal/SelfAssessments/SelfAssessmentProcessViewModel.cs
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| namespace DigitalLearningSolutions.Web.ViewModels.LearningPortal.SelfAssessments | ||
| { | ||
| using System.Collections.Generic; | ||
| using DigitalLearningSolutions.Data.Models.SelfAssessments; | ||
| using DigitalLearningSolutions.Web.Attributes; | ||
| using DigitalLearningSolutions.Web.Helpers; | ||
|  | ||
| public class SelfAssessmentProcessViewModel | ||
| { | ||
| public int SelfAssessmentID { get; set; } | ||
| [BooleanMustBeTrue(ErrorMessage = "Please tick the checkbox to confirm that you understand and agree to the self-assessment process")] | ||
| public bool ActionConfirmed { get; set; } | ||
|  | ||
| public string? VocabPlural { get; set; } | ||
| public string? Vocabulary { get; set; } | ||
|  | ||
| } | ||
| } | 
        
          
          
            57 changes: 57 additions & 0 deletions
          
          57 
        
  ...rningSolutions.Web/Views/LearningPortal/SelfAssessments/AgreeSelfAssessmentProcess.cshtml
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| @using DigitalLearningSolutions.Web.Extensions | ||
| @using DigitalLearningSolutions.Web.ViewModels.LearningPortal.SelfAssessments; | ||
| @model SelfAssessmentProcessViewModel | ||
| @{ | ||
| var errorHasOccurred = !ViewData.ModelState.IsValid; | ||
| ViewData["Title"] = (errorHasOccurred ? "Error: " : "") + "Agree To Process"; | ||
| ViewData["Application"] = "LearningPortal"; | ||
| ViewData["HeaderPathName"] = "LearningPortal"; | ||
| } | ||
|  | ||
| @section NavMenuItems { | ||
| <partial name="Shared/_NavMenuItems" /> | ||
| } | ||
|  | ||
| <div class="nhsuk-grid-row"> | ||
| <div class="nhsuk-grid-column-full word-break"> | ||
| @if (errorHasOccurred) | ||
| { | ||
| <vc:error-summary order-of-property-names="@(new[] { nameof(Model.ActionConfirmed) })" /> | ||
| } | ||
| <h2>How are @Model.VocabPlural?.ToLower() and frameworks assessed?</h2> | ||
|  | ||
| <p>The process is learner-driven but you must be assessed by a supervisor before completing a self-assessment.</p> | ||
|  | ||
| <p>Once enrolled in a framework with at least 1 supervisor added, you can complete a digital self-assessment for any @Model.Vocabulary?.ToLower(). However, before doing so, ensure that:</p> | ||
|  | ||
| <ol> | ||
| <li>Your supervisor can sign-off this @Model.Vocabulary?.ToLower() based on their competence or department requirements.</li> | ||
| <li>You have been formally assessed, this could be through observation, discussion, or another agreed method with your supervisor.</li> | ||
| <li>You have reflected on the @Model.Vocabulary?.ToLower() description and feel you meet the requirements.</li> | ||
| <li>If you don’t fully meet the requirements, you can still document your progress and next steps for future assessment.</li> | ||
| </ol> | ||
|  | ||
| <form method="post" asp-controller="LearningPortal" asp-action="ProcessAgreed"> | ||
| <div class="nhsuk-checkboxes__item"> | ||
| <vc:single-checkbox asp-for="@nameof(Model.ActionConfirmed)" | ||
| label=" I understand and agree to the self-assessment process described above." | ||
| hint-text="" /> | ||
| </div> | ||
| <button type="submit" class="nhsuk-button nhsuk-u-margin-top-4"> | ||
| Continue | ||
| </button> | ||
| <input type="hidden" asp-for="SelfAssessmentID" /> | ||
| <input type="hidden" asp-for="Vocabulary" /> | ||
| <input type="hidden" asp-for="VocabPlural" /> | ||
| </form> | ||
| <div class="nhsuk-back-link"> | ||
| <a class="nhsuk-back-link__link" asp-controller="LearningPortal" | ||
| asp-action="Current"> | ||
| <svg class="nhsuk-icon nhsuk-icon__chevron-left" focusable='false' xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" aria-hidden="true" focusable="false"> | ||
| <path d="M13.41 12l5.3-5.29a1 1 0 1 0-1.42-1.42L12 10.59l-5.29-5.3a1 1 0 0 0-1.42 1.42l5.3 5.29-5.3 5.29a1 1 0 0 0 0 1.42 1 1 0 0 0 1.42 0l5.29-5.3 5.29 5.3a1 1 0 0 0 1.42 0 1 1 0 0 0 0-1.42z"></path> | ||
| </svg> | ||
| Cancel | ||
| </a> | ||
| </div> | ||
| </div> | ||
| </div> | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should maybe try to do something cleaner here, maybe we can set this through this view's specific controller method. We can assign values technically on the view pages but they should be simpler and not involving a ternary operation.