Skip to content

Conversation

@Swapnamol
Copy link
Contributor

@Swapnamol Swapnamol commented Oct 2, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-4388

Description

Assessment resource settings need a required field marker - Fixed the SIT defects

Screenshots

Without description

image

With Description

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@Swapnamol Swapnamol requested a review from OluwatobiAwe October 2, 2024 14:25
@Swapnamol Swapnamol merged commit 40a4ff2 into RC Oct 2, 2024
2 checks passed
@Swapnamol Swapnamol deleted the Develop/Fixes/LH/TD-4388-Assessment-resource-settings-need-a-required-field-marker branch October 2, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants