Skip to content

TD-4388: Assessment resource settings need a required field marker #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge RC changes into CI
merged 1 commit into from
Oct 2, 2024
Merged

TD-4388: Assessment resource settings need a required field marker #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions LearningHub.Nhs.WebUI/Scripts/vuesrc/contribute-resource/ContributeAssessmentSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@

<div class="d-flex">
<div class="selection pr-50">
<div>Provide guidance for the learner at the end of this assessment. <i class="warningTriangle fas fa-exclamation-triangle warm-yellow"></i></div>
<div>Provide guidance for the learner at the end of this assessment. <i v-if="!IsVisible" class="warningTriangle fas fa-exclamation-triangle warm-yellow"></i></div>
<EditSaveFieldWithCharacterCount v-model="assessmentDetails.endGuidance.blocks[0].title"
addEditLabel="title"
v-bind:characterLimit="60"
Expand All @@ -79,7 +79,7 @@
<h3>Tip</h3>
You can offer guidance to the learner at the end of the assessment such as next steps or recommendations on other learning resources to try. </div>
</div>
<Button class="mt-5" color="green" v-on:click="isOpen = false" :disabled="!canSaveAll">Save settings</Button>
<Button class="mt-5" color="green" v-on:click="isOpen = false" :disabled="!IsVisible">Save settings</Button>
</div>
</div>
</v-card>
Expand Down Expand Up @@ -131,6 +131,7 @@
endGuidance: "",
initialGuidance: "",
guidanceValid: true,
IsVisible: false,
}
},
watch: {
Expand All @@ -139,7 +140,7 @@
{
this.assessmentDetails.endGuidance.addBlock(BlockTypeEnum.Text);
}
this.assessmentDetails.endGuidance.blocks[0].textBlock.content = this.endGuidance;
this.assessmentDetails.endGuidance.blocks[0].textBlock.content = this.endGuidance;
},
["assessmentDetails.passMark"](value){ this.assessmentDetails.passMark = this.capNumberFieldBy(value, 100)},
["assessmentDetails.maximumAttempts"](value){ this.assessmentDetails.maximumAttempts = this.capNumberFieldBy(value, 10)},
Expand All @@ -156,6 +157,14 @@
}

this.assessmentDetails.assessmentSettingsAreValid = settingsAreValid;

if (this.endGuidance != "") {
this.IsVisible = true;
}
else {
this.IsVisible = false;
}

return settingsAreValid;
},
},
Expand All @@ -169,9 +178,23 @@
{
this.endGuidance = description;
}

if (this.endGuidance != "") {
this.IsVisible = true;
}
else {
this.IsVisible = false;
}
},
setGuidanceValidity(valid: boolean) {
this.guidanceValid = valid;
if (this.endGuidance == "") {
this.guidanceValid = false;
this.IsVisible = false;
}
else {
this.guidanceValid = valid;
this.IsVisible = true;
}
}
}
});
Expand Down
Loading