Development of P1 P2 and P3 Endpoints

[OluwatobiAwe]

JIRA link

TD-5118

Description

Import P1 P2 and P3 endpoint from the Web API project into the Open API project

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
• Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
• Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
• Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
• Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
  Either:
• Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • doc_1_here
    Or:
• Confirmed that none of the work that I have undertaken requires any updates to documentation

[kevwhitt-hee]

Great work, @OluwatobiAwe. A few of the interface classes seem to have some unnecessary using references. Please could we review and remove any that are not needed.

[kevwhitt-hee]

@afchaves, @AnjuJose011, @ColinBeebyHEE, @rshrirohit, I will schedule an all dev team meeting to discuss next steps for OpenAPI work. I think we ought to:

• switch to using the OpenAPI within our internal services
• get into better practices with maintaining and documenting the Open API
• remove WebAPI equivalents when we have replaced them
• use this approach as the basis for the same in DLS
  Please share any thoughts ahead of the meeting.

[AnjuJose011]

LearningHubTenantId has no values. Are we setting this value from pipeline?

[OluwatobiAwe]

This has now been updated. But I'll be re-validating all appsettings variables in the pipeline before it's released to test