fix(Makefile): Update top level makefile commands for am62xx-lp-evm#331
Closed
jeevantelukula wants to merge 1 commit intoTexasInstruments:masterfrom
Closed
fix(Makefile): Update top level makefile commands for am62xx-lp-evm#331jeevantelukula wants to merge 1 commit intoTexasInstruments:masterfrom
jeevantelukula wants to merge 1 commit intoTexasInstruments:masterfrom
Conversation
A new variable YOCTO_MACHINE is to be passed as argument for building via top level makefile for AM62-LP. Update docs accordingly. Signed-off-by: Telukula Jeevan Kumar Sahu <j-sahu@ti.com>
jeevantelukula
requested review from
StaticRocket,
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
cshilwant
reviewed
Jun 23, 2025
Member
cshilwant
left a comment
cshilwant
left a comment
There was a problem hiding this comment.
Asking users to pass same arguments twice to 2 different variables is redundant.
Why can't we update YOCTO_MACHINE to am62xx-lp-evm inside this if condition - https://github.com/TexasInstruments/ti-tisdk-makefile/blob/master/configs/platforms/am62xx-evm.mk#L25
After which this PR isn't required
Collaborator
Author
|
Sounds good. Created PR in tisdk-makefile: TexasInstruments/ti-tisdk-makefile#40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new variable YOCTO_MACHINE is to be passed as argument for building via top level makefile for AM62-LP. Update docs accordingly.