ci: add rules for rapidus2hp designs#3376
Merged
maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom Aug 4, 2025
Merged
ci: add rules for rapidus2hp designs#3376maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom
maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Use correct name SKIP_DETAILED_ROUTE instead of SKIP_DRT. Since SKIP_DETAILED_ROUTE is defined at variables.yaml it will always exist in the route stage, so the check env_var_exists_and_non_empty will always be true. The check should be done with env_var_equals. Since the variable is also used in the final stage to decide if OpenRCX should run we need "final" included in the variables.yaml file. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Member
idk what this means |
maliberty
approved these changes
Aug 4, 2025
Collaborator
I left a review comment for @jeffng-or w.r.t. the problem that he ran into w.r.t. spelling errors on variable names and had some ideas on syntax check of variables |
Member
|
hmm... I don't see any comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rules files for rapidus2hp.
Use the correct name SKIP_DETAILED_ROUTE instead of SKIP_DRT.
Since SKIP_DETAILED_ROUTE is defined at variables.yaml it will always exist
in the route stage, so the check env_var_exists_and_non_empty will always
be true. The check should be done with env_var_equals. Since the variable
is also used in the final stage to decide if OpenRCX should run, we need
"final" included in the variables.yaml file.