ODB: Allow multiple chip def reads#8140
Merged
maliberty merged 11 commits intoThe-OpenROAD-Project:masterfrom Sep 10, 2025
Merged
ODB: Allow multiple chip def reads#8140maliberty merged 11 commits intoThe-OpenROAD-Project:masterfrom
maliberty merged 11 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
QuantamHD
reviewed
Aug 28, 2025
…iles Signed-off-by: Osama <osama21@aucegypt.edu>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Summarizing a conversation with @QuantamHD I think he would like to see us not need both of these args: I think the best way to fix that is to move the dbTech to be associated with the dbChip rather than the dbBlock. It feels more semantically accurate as you can't have multiple techs on a single chip. |
2- move dbTech from dbBlock to dbChip. 3- Update dbChip and dbBlock creation APIs. 4- Update Tcl scripts and tests to reflect these changes. Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows specifying the chip to populate with the read_def command. Needed for multiple chips in the same database.