rsz: reportFastBufferSizes() now sorts its cells before reporting.#8699
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Oct 22, 2025
Merged
rsz: reportFastBufferSizes() now sorts its cells before reporting.#8699maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
povik
approved these changes
Oct 22, 2025
Contributor
povik
left a comment
There was a problem hiding this comment.
Looks fine, only needs the clang tidy fix
49dd1a5 to
3a0572f
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
908c52d to
ad27045
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
d6e3998 to
ef38fc3
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Oct 22, 2025
maliberty
approved these changes
Oct 22, 2025
Signed-off-by: Ted Hong <tedhong@google.com>
auto-merge was automatically disabled
October 22, 2025 23:16
Head branch was pushed to by a user without write access
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards resolving #8698