Conversation
Since the loop body wasn't changing `_region->groups_` the loop got stuck on the first element and never progressed past it. This hang can be reproduced with: set block [ord::get_db_block] set foo_region [odb::dbRegion_create $block foo_region] set foo_group [odb::dbGroup_create $foo_region foo_group] odb::dbRegion_destroy $foo_region Signed-off-by: Martin Povišer <povik@cutebit.org>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Please add a unit test |
Signed-off-by: Martin Povišer <povik@cutebit.org>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
povik
reviewed
Dec 2, 2025
| tearDown $db | ||
| } | ||
|
|
||
| proc test_region_w_groups_destroy { } { |
Member
|
I suspect the code was wrong before your change and is still so. will prevent dbRegionGroupItr::next from advancing to the next group. Does you test work if you have two groups assigned to one region? |
Contributor
|
I don't think we ever call |
Member
|
I see, I didn't notice it wasn't using ++. |
maliberty
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the loop body wasn't changing
_region->groups_the loop got stuck on the first element and never progressed past it. This hang can be reproduced with:Thanks to @dbekatli for help.