grt: remove pre-progress message vestiges #9197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Øyvind Harboe <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a verbose log message and updates the corresponding test outputs. The change is straightforward. I've added one comment suggesting to replace the removed log message with a code comment to preserve the context for the logic, which would improve maintainability.
I am having trouble creating individual review comments. Click here to see my feedback.
src/grt/src/fastroute/src/FastRoute.cpp (1594-1596)
The removed log message Extra Run for hard benchmark. provided useful context for this special-cased logic. Without it, the conditions i == 20 && past_cong > 200 and the subsequent state changes are less clear. To maintain code readability, please consider adding a comment explaining the purpose of this block, for instance:
// Extra run for hard-to-route benchmarks.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
eder-matheus
approved these changes
Jan 5, 2026
Collaborator
Author
|
😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.