Skip to content

Conversation

BKarthik7
Copy link
Contributor

Description of Change

This pull request implements the Gale-Shapley algorithm for stable marriage matching. It includes the logic for handling preferences of both men and women, ensuring stable matches based on their preferences.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: This implementation provides three test cases to demonstrate the functionality of the algorithm, ensuring that the program works as intended under different scenarios.

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. There are several issues to be addressed.

This algorithm could be further generalized in my opinion because this is very specific to the stable marriage problem but feel free to discuss this.

@realstealthninja realstealthninja added awaiting modification Do not merge until modifications are made requested changes changes have been requested Proper Documentation Required requested to write the documentation properly labels Oct 1, 2024
@BKarthik7
Copy link
Contributor Author

I think I resolved all the conversations

@BKarthik7
Copy link
Contributor Author

BKarthik7 commented Oct 2, 2024

@realstealthninja is there anything else for review

@BKarthik7 BKarthik7 marked this pull request as draft October 3, 2024 08:38
@BKarthik7 BKarthik7 marked this pull request as ready for review October 3, 2024 08:39
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions and patience a little more and we can get this merged! ♥️

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@realstealthninja realstealthninja added approved Approved; waiting for merge and removed awaiting modification Do not merge until modifications are made requested changes changes have been requested Proper Documentation Required requested to write the documentation properly labels Oct 4, 2024
@realstealthninja realstealthninja merged commit 901f231 into TheAlgorithms:master Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants