-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat: Added gale_shapley.cpp in greedy_algorithms #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. There are several issues to be addressed.
This algorithm could be further generalized in my opinion because this is very specific to the stable marriage problem but feel free to discuss this.
I think I resolved all the conversations |
@realstealthninja is there anything else for review |
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions and patience a little more and we can get this merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description of Change
This pull request implements the Gale-Shapley algorithm for stable marriage matching. It includes the logic for handling preferences of both men and women, ensuring stable matches based on their preferences.
Checklist
Notes: This implementation provides three test cases to demonstrate the functionality of the algorithm, ensuring that the program works as intended under different scenarios.